From patchwork Thu Jun 12 12:09:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Blanchard X-Patchwork-Id: 359093 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6185A1400D5 for ; Thu, 12 Jun 2014 22:09:45 +1000 (EST) Received: from ozlabs.org (ozlabs.org [103.22.144.67]) by lists.ozlabs.org (Postfix) with ESMTP id 48F9E1A0992 for ; Thu, 12 Jun 2014 22:09:45 +1000 (EST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 168791A0338 for ; Thu, 12 Jun 2014 22:09:15 +1000 (EST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 421921400D5; Thu, 12 Jun 2014 22:09:14 +1000 (EST) Date: Thu, 12 Jun 2014 22:09:12 +1000 From: Anton Blanchard To: Christoph Lameter Subject: Re: Kernel build issues after yesterdays merge by Linus Message-ID: <20140612220912.3447677f@kryten> In-Reply-To: References: X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: Rusty Russell , linuxppc-dev@lists.ozlabs.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Christoph, > This is under Ubuntu Utopic Unicorn on a Power 8 system while simply > trying to build with the Ubuntu standard kernel config. It could be > that these issues come about because we do not have an rc1 yet but I > wanted to give some early notice. Also this is a new arch to me so I > may not be aware of how things work. > > 1. Bad relocation while building: > > root@rd-power8:/rdhome/clameter/linux# make > CHK include/config/kernel.release > CHK include/generated/uapi/linux/version.h > CHK include/generated/utsrelease.h > CALL scripts/checksyscalls.sh > CHK include/generated/compile.h > SKIPPED include/generated/compile.h > CALL arch/powerpc/kernel/systbl_chk.sh > CALL arch/powerpc/kernel/prom_init_check.sh > CHK kernel/config_data.h > CALL arch/powerpc/relocs_check.pl > WARNING: 1 bad relocations > c000000000cc7df0 R_PPC64_ADDR64 __crc_TOC. The TOC symbol export is special and I think we might need to get our script to ignore it. > 2. "make install" fails > > root@rd-power8:/rdhome/clameter/linux# make install > sh -x /rdhome/clameter/linux/arch/powerpc/boot/install.sh "3.15.0+" > vmlinux System.map "/boot" arch/powerpc/boot/zImage.pseries > arch/powerpc/boot/zImage.epapr > + set -e > + [ -x /home/clameter/bin/installkernel ] > + [ -x /sbin/installkernel ] > + exec /sbin/installkernel 3.15.0+ vmlinux System.map /boot > arch/powerpc/boot/zImage.pseries arch/powerpc/boot/zImage.epapr > Usage: installkernel > /rdhome/clameter/linux/arch/powerpc/boot/Makefile:393: recipe for target > 'install' failed > make[1]: *** [install] Error 1 > /rdhome/clameter/linux/arch/powerpc/Makefile:294: recipe for target > 'install' failed > make: *** [install] Error 2 Shows how much we use make install :) Below is a quick hack to get you going but we should look at either fixing the Ubuntu installkernel to handle extra optional args, or stop passing them from the ppc64 kernel install.sh script. Anton diff --git a/arch/powerpc/boot/install.sh b/arch/powerpc/boot/install.sh index b6a256b..e096e5a 100644 --- a/arch/powerpc/boot/install.sh +++ b/arch/powerpc/boot/install.sh @@ -23,8 +23,8 @@ set -e # User may have a custom install script -if [ -x ~/bin/${INSTALLKERNEL} ]; then exec ~/bin/${INSTALLKERNEL} "$@"; fi -if [ -x /sbin/${INSTALLKERNEL} ]; then exec /sbin/${INSTALLKERNEL} "$@"; fi +if [ -x ~/bin/${INSTALLKERNEL} ]; then exec ~/bin/${INSTALLKERNEL} $1 $2 $3 $4; fi +if [ -x /sbin/${INSTALLKERNEL} ]; then exec /sbin/${INSTALLKERNEL} $1 $2 $3 $4; fi # Default install