From patchwork Wed Jun 10 00:38:57 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Brownell X-Patchwork-Id: 28359 Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id DD1B1B70D0 for ; Wed, 10 Jun 2009 10:46:37 +1000 (EST) Received: by ozlabs.org (Postfix) id D1FC6DDD0C; Wed, 10 Jun 2009 10:46:37 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (bilbo.ozlabs.org [203.10.76.25]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "bilbo.ozlabs.org", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id CF6B0DDD0B for ; Wed, 10 Jun 2009 10:46:37 +1000 (EST) Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by bilbo.ozlabs.org (Postfix) with ESMTP id E740AB73AF for ; Wed, 10 Jun 2009 10:46:03 +1000 (EST) Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 2F154B707F for ; Wed, 10 Jun 2009 10:45:57 +1000 (EST) Received: by ozlabs.org (Postfix) id 1B85DDDD0B; Wed, 10 Jun 2009 10:45:57 +1000 (EST) Delivered-To: linuxppc-dev@ozlabs.org X-Greylist: delayed 397 seconds by postgrey-1.31 at ozlabs; Wed, 10 Jun 2009 10:45:56 EST Received: from smtp101.sbc.mail.gq1.yahoo.com (smtp101.sbc.mail.gq1.yahoo.com [67.195.15.60]) by ozlabs.org (Postfix) with SMTP id 1CB7EDDD01 for ; Wed, 10 Jun 2009 10:45:55 +1000 (EST) Received: (qmail 76681 invoked from network); 10 Jun 2009 00:39:14 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=e9OcAUW68d454nih5PmQBCFm4VTje8qpaKLfyunZodKytZgAcldPuHzhHlddamsZ+AafEzDb5uXP++Cb+mQc/WR9jndg3dypTr0/7e5EBVEkZ23/pVLoM4e/xGUb/+Ci14axZIoZaFhlE4hjzCtvmlTpdNCPxKmnMuV9jnFBddw= ; Received: from unknown (HELO pogo.local) (david-b@99.187.238.5 with plain) by smtp101.sbc.mail.gq1.yahoo.com with SMTP; 10 Jun 2009 00:39:13 -0000 X-Yahoo-SMTP: HIlLYKCswBDnjrunw3O.NnLyvismjGf1HBYfVTvuneM- X-YMail-OSG: WoGg3.IVM1mCMPByxCesIFQgXDf_ZfF_cGhq4pD1xZto9x54xv2FYY4AEwZU9bHBY4WZMAIOpnHzQx8.o7GbWt6Q71acFhWNs1WRyMXDhtcO6UbGAoQ.TtfOcOxWNckCOwOL6MXDxzWCvU.X7zgc4xGZtnOVDfhQSY72T3C3v0NsYp2Om_wP._Bcclx3mvsEDyp0lQyQAXRSaoOZT_I.16F0Owbs.9nJdzzfAcG._CkIIpifdW9idhvx5.vvBcF8WPU35.4BZCTWE1FnIdGIvoq.xt7N7VPP6x26z2dTr83KID.0INDpNbniXg4_6wCStsR_M6pzyA-- X-Yahoo-Newman-Property: ymail-3 From: David Brownell To: Subrata Modak , Arnd Bergmann Subject: Re: [BUILD FAILURE 02/04] Next June 04:PPC64 randconfig [drivers/usb/host/ohci-hcd.o] Date: Tue, 9 Jun 2009 17:38:57 -0700 User-Agent: KMail/1.9.10 References: <20090605182651.24094.36577.sendpatchset@elm3a191.beaverton.ibm.com> In-Reply-To: <20090605182651.24094.36577.sendpatchset@elm3a191.beaverton.ibm.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200906091738.58154.david-b@pacbell.net> Cc: Sachin P Sant , Randy Dunlap , Stephen Rothwell , linux-usb@vger.kernel.org, Linux-Kernel , Linuxppc-dev , Linux-Next , kernel@wantstofly.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org On Friday 05 June 2009, Subrata Modak wrote: > Correct, it fixes the issue. However, since few changes might have gone > to the Kconfig, the patch does not apply cleanly. Below is the patch, just > a retake of the earlier one, but on the latest code. And it got mangled a bit along the way. Plus, the original one goofed up Kconfig dependency displays ... both issues fixed in this version, against current mainline GIT. If someone can verify all four PPC/OF/OHCI configs build on on PPC64, I'm OK with it. - Dave ========== CUT HERE From: Arnd Bergmann Subject: fix build failure for PPC64 randconfig [usb/ohci] We could just make the USB_OHCI_HCD_PPC_OF option implicit and selected only if at least one of USB_OHCI_HCD_PPC_OF_BE and USB_OHCI_HCD_PPC_OF_LE are set. [ dbrownell@users.sourceforge.net: fix patch manglation and dependencies ] Signed-off-by: Arnd Bergmann Resent-by: Subrata Modak Signed-off-by: David Brownell --- drivers/usb/host/Kconfig | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -180,26 +180,27 @@ config USB_OHCI_HCD_PPC_SOC Enables support for the USB controller on the MPC52xx or STB03xxx processor chip. If unsure, say Y. -config USB_OHCI_HCD_PPC_OF - bool "OHCI support for PPC USB controller on OF platform bus" - depends on USB_OHCI_HCD && PPC_OF - default y - ---help--- - Enables support for the USB controller PowerPC present on the - OpenFirmware platform bus. - config USB_OHCI_HCD_PPC_OF_BE - bool "Support big endian HC" - depends on USB_OHCI_HCD_PPC_OF - default y + bool "OHCI support for OF platform bus (big endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_BIG_ENDIAN_DESC select USB_OHCI_BIG_ENDIAN_MMIO + ---help--- + Enables support for big-endian USB controllers present on the + OpenFirmware platform bus. config USB_OHCI_HCD_PPC_OF_LE - bool "Support little endian HC" - depends on USB_OHCI_HCD_PPC_OF - default n + bool "OHCI support for OF platform bus (little endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_LITTLE_ENDIAN + ---help--- + Enables support for little-endian USB controllers present on the + OpenFirmware platform bus. + +config USB_OHCI_HCD_PPC_OF + bool + depends on USB_OHCI_HCD && PPC_OF + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE config USB_OHCI_HCD_PCI bool "OHCI support for PCI-bus USB controllers"