| Message ID | 1614840015-1535-1-git-send-email-atrajeev@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | powerpc/perf: Fix the threshold event selection for memory events in power10 | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (626a6c3d2e20da80aaa710104f34ea6037b28b33) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| snowpatch_ozlabs/needsstable | warning | Please consider tagging this patch for stable! |
On 3/4/21 12:10 PM, Athira Rajeev wrote: > Memory events (mem-loads and mem-stores) currently use the threshold > event selection as issue to finish. Power10 supports issue to complete > as part of thresholding which is more appropriate for mem-loads and > mem-stores. Hence fix the event code for memory events to use issue > to complete. Changes looks fine to me. Reviewed-by: Madhavan Srinivasan <maddy@linux.ibm.com> We should also CC stable to include this fix? > Fixes: a64e697cef23 ("powerpc/perf: power10 Performance Monitoring support") > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > --- > arch/powerpc/perf/power10-events-list.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/perf/power10-events-list.h b/arch/powerpc/perf/power10-events-list.h > index e45dafe818ed..93be7197d250 100644 > --- a/arch/powerpc/perf/power10-events-list.h > +++ b/arch/powerpc/perf/power10-events-list.h > @@ -75,5 +75,5 @@ > * thresh end (TE) > */ > > -EVENT(MEM_LOADS, 0x34340401e0); > -EVENT(MEM_STORES, 0x343c0401e0); > +EVENT(MEM_LOADS, 0x35340401e0); > +EVENT(MEM_STORES, 0x353c0401e0);
On Thu, 4 Mar 2021 01:40:15 -0500, Athira Rajeev wrote: > Memory events (mem-loads and mem-stores) currently use the threshold > event selection as issue to finish. Power10 supports issue to complete > as part of thresholding which is more appropriate for mem-loads and > mem-stores. Hence fix the event code for memory events to use issue > to complete. Applied to powerpc/next. [1/1] powerpc/perf: Fix the threshold event selection for memory events in power10 https://git.kernel.org/powerpc/c/66d9b7492887d34c711bc05b36c22438acba51b4 cheers
diff --git a/arch/powerpc/perf/power10-events-list.h b/arch/powerpc/perf/power10-events-list.h index e45dafe818ed..93be7197d250 100644 --- a/arch/powerpc/perf/power10-events-list.h +++ b/arch/powerpc/perf/power10-events-list.h @@ -75,5 +75,5 @@ * thresh end (TE) */ -EVENT(MEM_LOADS, 0x34340401e0); -EVENT(MEM_STORES, 0x343c0401e0); +EVENT(MEM_LOADS, 0x35340401e0); +EVENT(MEM_STORES, 0x353c0401e0);
Memory events (mem-loads and mem-stores) currently use the threshold event selection as issue to finish. Power10 supports issue to complete as part of thresholding which is more appropriate for mem-loads and mem-stores. Hence fix the event code for memory events to use issue to complete. Fixes: a64e697cef23 ("powerpc/perf: power10 Performance Monitoring support") Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> --- arch/powerpc/perf/power10-events-list.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)