| Message ID | 1549885032-15702-1-git-send-email-thuth@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 24c174bb23ebcbe4c3979855b220513f2b3a730f |
| Headers | show |
| Series | powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/build-ppc64le | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64be | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64e | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-pmac32 | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
On Mon, 11 Feb 2019 12:37:12 +0100 Thomas Huth <thuth@redhat.com> wrote: > Recent versions of QEMU provide a XHCI device by default these > days instead of an old-fashioned OHCI device: > > https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27 > > So to get the keyboard working in the graphical console there again, > we should now include XHCI support in the kernel by default, too. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Wow, we didn't before? That's bonkers. Reviewed-by: David Gibson <david@gibson.dropbear.id.au> > --- > arch/powerpc/configs/pseries_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig > index ea79c51..62e12f6 100644 > --- a/arch/powerpc/configs/pseries_defconfig > +++ b/arch/powerpc/configs/pseries_defconfig > @@ -217,6 +217,7 @@ CONFIG_USB_MON=m > CONFIG_USB_EHCI_HCD=y > # CONFIG_USB_EHCI_HCD_PPC_OF is not set > CONFIG_USB_OHCI_HCD=y > +CONFIG_USB_XHCI_HCD=y > CONFIG_USB_STORAGE=m > CONFIG_NEW_LEDS=y > CONFIG_LEDS_CLASS=m > -- > 1.8.3.1 >
On Mon, 11 Feb 2019 at 22:07, Thomas Huth <thuth@redhat.com> wrote: > > Recent versions of QEMU provide a XHCI device by default these > days instead of an old-fashioned OHCI device: > > https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27 "recent" :D > So to get the keyboard working in the graphical console there again, > we should now include XHCI support in the kernel by default, too. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Acked-by: Joel Stanley <joel@jms.id.au> > --- > arch/powerpc/configs/pseries_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig > index ea79c51..62e12f6 100644 > --- a/arch/powerpc/configs/pseries_defconfig > +++ b/arch/powerpc/configs/pseries_defconfig > @@ -217,6 +217,7 @@ CONFIG_USB_MON=m > CONFIG_USB_EHCI_HCD=y > # CONFIG_USB_EHCI_HCD_PPC_OF is not set > CONFIG_USB_OHCI_HCD=y > +CONFIG_USB_XHCI_HCD=y > CONFIG_USB_STORAGE=m > CONFIG_NEW_LEDS=y > CONFIG_LEDS_CLASS=m > -- > 1.8.3.1 >
On 12/02/2019 00.31, David Gibson wrote: > On Mon, 11 Feb 2019 12:37:12 +0100 > Thomas Huth <thuth@redhat.com> wrote: > >> Recent versions of QEMU provide a XHCI device by default these >> days instead of an old-fashioned OHCI device: >> >> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27 >> >> So to get the keyboard working in the graphical console there again, >> we should now include XHCI support in the kernel by default, too. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> > > Wow, we didn't before? That's bonkers. > > Reviewed-by: David Gibson <david@gibson.dropbear.id.au> > >> --- >> arch/powerpc/configs/pseries_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig >> index ea79c51..62e12f6 100644 >> --- a/arch/powerpc/configs/pseries_defconfig >> +++ b/arch/powerpc/configs/pseries_defconfig >> @@ -217,6 +217,7 @@ CONFIG_USB_MON=m >> CONFIG_USB_EHCI_HCD=y >> # CONFIG_USB_EHCI_HCD_PPC_OF is not set >> CONFIG_USB_OHCI_HCD=y >> +CONFIG_USB_XHCI_HCD=y >> CONFIG_USB_STORAGE=m >> CONFIG_NEW_LEDS=y >> CONFIG_LEDS_CLASS=m >> -- >> 1.8.3.1 Ping? Thomas
Thomas Huth <thuth@redhat.com> writes: > On 12/02/2019 00.31, David Gibson wrote: >> On Mon, 11 Feb 2019 12:37:12 +0100 >> Thomas Huth <thuth@redhat.com> wrote: >> >>> Recent versions of QEMU provide a XHCI device by default these >>> days instead of an old-fashioned OHCI device: >>> >>> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27 >>> >>> So to get the keyboard working in the graphical console there again, >>> we should now include XHCI support in the kernel by default, too. >>> >>> Signed-off-by: Thomas Huth <thuth@redhat.com> >> >> Wow, we didn't before? That's bonkers. >> >> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> >> >>> --- >>> arch/powerpc/configs/pseries_defconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig >>> index ea79c51..62e12f6 100644 >>> --- a/arch/powerpc/configs/pseries_defconfig >>> +++ b/arch/powerpc/configs/pseries_defconfig >>> @@ -217,6 +217,7 @@ CONFIG_USB_MON=m >>> CONFIG_USB_EHCI_HCD=y >>> # CONFIG_USB_EHCI_HCD_PPC_OF is not set >>> CONFIG_USB_OHCI_HCD=y >>> +CONFIG_USB_XHCI_HCD=y >>> CONFIG_USB_STORAGE=m >>> CONFIG_NEW_LEDS=y >>> CONFIG_LEDS_CLASS=m >>> -- >>> 1.8.3.1 > > Ping? Sorry, will pick it up. cheers
diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig index ea79c51..62e12f6 100644 --- a/arch/powerpc/configs/pseries_defconfig +++ b/arch/powerpc/configs/pseries_defconfig @@ -217,6 +217,7 @@ CONFIG_USB_MON=m CONFIG_USB_EHCI_HCD=y # CONFIG_USB_EHCI_HCD_PPC_OF is not set CONFIG_USB_OHCI_HCD=y +CONFIG_USB_XHCI_HCD=y CONFIG_USB_STORAGE=m CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=m
Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27 So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too. Signed-off-by: Thomas Huth <thuth@redhat.com> --- arch/powerpc/configs/pseries_defconfig | 1 + 1 file changed, 1 insertion(+)