From patchwork Thu Oct 18 22:46:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Rowand X-Patchwork-Id: 986376 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42bkx84nS2z9sCQ for ; Fri, 19 Oct 2018 09:58:36 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IKvuIkbT"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42bkx83Dv6zF3DW for ; Fri, 19 Oct 2018 09:58:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IKvuIkbT"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=frowand.list@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IKvuIkbT"; dkim-atps=neutral Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42bkj66GNXzF3FK for ; Fri, 19 Oct 2018 09:48:10 +1100 (AEDT) Received: by mail-pf1-x442.google.com with SMTP id r64-v6so15534422pfb.13 for ; Thu, 18 Oct 2018 15:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9C70m4ZYW6bahYInRPebhsLk8Qt5u47Y5Ga7mt8v3gU=; b=IKvuIkbTbm2ZsyB6wxfEV8nvYYPxaG8Q3MWtDjHRUQXn0w4mTsaTEV0nFKlpvxqEJM rtskc9wujBBC8WV9CRHZQusuuIUIbiMqIp5NzT+MGqGuGcNMKTcPVVrphzylade21Gfa J2dA65DcFYors6/9ZFr2bc6WuW9duBueUd7mAU4WnMzvjrpiPuf27m2mlXUTwZMqiVoc 5ePRvOCmowx8I9dwPHiGiDDG5rTFdceTkF4a49QI7Kv2DWP4DyZ2JQ9QKttVOewkOh4a xH5i5DpRzxVpyl9RuXW0+xHw94U0cFM7u9sal+xnS1P5Kek8anhUdz6RPWf1S5yh6OnH lAtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9C70m4ZYW6bahYInRPebhsLk8Qt5u47Y5Ga7mt8v3gU=; b=Ksr+udQQ2wTO0lxNBUlisLFaFKq5WUsZvu6QFE6wz0hSaBef42/xEPGuWThkgHQ3LV kP+hAREV2Q2Ku/MBZswP8XZvARfBOZe5oav4zfctZ27wlPYLjwWKm+P/GpoHO3qSgEdj 2bXyrfk1IwlPm/7NGnEKZZfRcH2eZhmMFGWEKxYHEiLb6AYC51yWag3+so1REwR4OYbF nQjHb0W83+WH8P4FiukQYWsyYHqe46au6ze+I7dZ/M8h9iih3RB/Thr+LAYMl7+8OYFr vZ86O8OathUnKtlZUN+W14Geg++KBM2Fj6ejRdaK+W+69NI+3+eROo12ZSwapCL/F+5Q A6bQ== X-Gm-Message-State: ABuFfojEgEjcCPw4rLryckTkpARTAYOezm5oA7z927VdVWcgwbNmxsRl R1/DljXMPNv0J8lDbJNTB5I= X-Google-Smtp-Source: ACcGV60DPgY00OK9dxZfMklbl8XGA1jMZMnVsKNtGEQeN9pASNM3SPnDAnDgiPhNchc+PUSFfrOeDA== X-Received: by 2002:a63:5d55:: with SMTP id o21-v6mr29769769pgm.349.1539902888661; Thu, 18 Oct 2018 15:48:08 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id v81-v6sm38129268pfj.25.2018.10.18.15.48.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Oct 2018 15:48:08 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Subject: [PATCH v5 03/18] of: overlay: add missing of_node_get() in __of_attach_node_sysfs Date: Thu, 18 Oct 2018 15:46:21 -0700 Message-Id: <1539902796-8382-4-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1539902796-8382-1-git-send-email-frowand.list@gmail.com> References: <1539902796-8382-1-git-send-email-frowand.list@gmail.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Frank Rowand There is a matching of_node_put() in __of_detach_node_sysfs() Remove misleading comment from function header comment for of_detach_node(). This patch may result in memory leaks from code that directly calls the dynamic node add and delete functions directly instead of using changesets. Signed-off-by: Frank Rowand --- This patch should result in powerpc systems that dynamically allocate a node, then later deallocate the node to have a memory leak when the node is deallocated. The next patch in the series will fix the leak. drivers/of/dynamic.c | 3 --- drivers/of/kobj.c | 4 +++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c index 12c3f9a15e94..146681540487 100644 --- a/drivers/of/dynamic.c +++ b/drivers/of/dynamic.c @@ -272,9 +272,6 @@ void __of_detach_node(struct device_node *np) /** * of_detach_node() - "Unplug" a node from the device tree. - * - * The caller must hold a reference to the node. The memory associated with - * the node is not freed until its refcount goes to zero. */ int of_detach_node(struct device_node *np) { diff --git a/drivers/of/kobj.c b/drivers/of/kobj.c index 7a0a18980b98..c72eef988041 100644 --- a/drivers/of/kobj.c +++ b/drivers/of/kobj.c @@ -133,6 +133,9 @@ int __of_attach_node_sysfs(struct device_node *np) } if (!name) return -ENOMEM; + + of_node_get(np); + rc = kobject_add(&np->kobj, parent, "%s", name); kfree(name); if (rc) @@ -159,6 +162,5 @@ void __of_detach_node_sysfs(struct device_node *np) kobject_del(&np->kobj); } - /* finally remove the kobj_init ref */ of_node_put(np); }