diff mbox series

[1/3] dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet

Message ID 1534510826-7603-1-git-send-email-21cnbao@gmail.com
State New
Headers show
Series [1/3] dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet | expand

Commit Message

Barry Song Aug. 17, 2018, 1 p.m. UTC
as you are already in a tasklet, it is unnecessary to call spin_lock_bh.

Signed-off-by: Barry Song <21cnbao@gmail.com>
---
 drivers/dma/fsldma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Vinod Koul Sept. 3, 2018, 10:55 a.m. UTC | #1
On 17-08-18, 06:00, Barry Song wrote:
> as you are already in a tasklet, it is unnecessary to call spin_lock_bh.

Applied all, thanks

You may want to check you send-mail options, they patches were all over
my inbox and npot threaded
diff mbox series

Patch

diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 1117b51..9d360a3 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -987,7 +987,7 @@  static void dma_do_tasklet(unsigned long data)
 
 	chan_dbg(chan, "tasklet entry\n");
 
-	spin_lock_bh(&chan->desc_lock);
+	spin_lock(&chan->desc_lock);
 
 	/* the hardware is now idle and ready for more */
 	chan->idle = true;
@@ -995,7 +995,7 @@  static void dma_do_tasklet(unsigned long data)
 	/* Run all cleanup for descriptors which have been completed */
 	fsldma_cleanup_descriptors(chan);
 
-	spin_unlock_bh(&chan->desc_lock);
+	spin_unlock(&chan->desc_lock);
 
 	chan_dbg(chan, "tasklet exit\n");
 }