From patchwork Thu Feb 22 01:55:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ram Pai X-Patchwork-Id: 876476 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zmz085qDlz9ryl for ; Thu, 22 Feb 2018 13:32:24 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SzDM2T8V"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zmz084VqrzDqFV for ; Thu, 22 Feb 2018 13:32:24 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SzDM2T8V"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400d:c09::241; helo=mail-qk0-x241.google.com; envelope-from=ram.n.pai@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SzDM2T8V"; dkim-atps=neutral Received: from mail-qk0-x241.google.com (mail-qk0-x241.google.com [IPv6:2607:f8b0:400d:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zmyCW1pRjzF0yc for ; Thu, 22 Feb 2018 12:57:11 +1100 (AEDT) Received: by mail-qk0-x241.google.com with SMTP id v124so4612413qkh.11 for ; Wed, 21 Feb 2018 17:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=pVXof952unrEX5OZWG7EovzxlbRLAhTrnbYTLlTuZ2A=; b=SzDM2T8VwFUNsFrOln2tZmCkvJ1CB8nVH+BucHLTsDLc82xUR9ehAN+f8ZzpvtRo2x 4c7fBAlgb8wK3fDHMFWJlmFHLJgSD+BKQF1yeWdAKjESoD55cRDilcXOhjfB/rWIIv2L Xhmn9i0+X+1WF6yEqs/XK3kUn/50dPRZiroe7/n6H+hjozOIpa4tJdEp2LS/QOzmI1sH SZDST5E/sj5caO89OTk/sF1gq1A/RjR+58kUYNxEjdH7eTDxm+rEdEPjsQ2zgxS6Qf2A LpVdtaqUqZTvOuy/WZJAlkJpDFGrxKZElbPf5Ki8oWA4sTplB6pR9z4xN3R1ibJImWGW DeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=pVXof952unrEX5OZWG7EovzxlbRLAhTrnbYTLlTuZ2A=; b=tzBVVZs0+uzS3XTriD4fBsPjO47O4rkrVNkSevQhBLCLi1hc4fI0Jvz6ZHlhCPrpTk CNhTfd0beVe58Iz4d0z5WpfjmdZU2R7WInMRyEBA5Sp5TuMBra+OshYmSzgJxc4a9WGo jlsfXAf7GxNw699Szud/MJPj1cbFtdqpftWbMp3K5HSq0adEBSlN6veHsgLsBNyeFlvR VjoWw5Vlr43e0P9Yt9b6TI4oeBmiNb6q+BVB7jsH2i1tLRs0M//JGD7Uz6KNmOg+qv+i h6lfqhJRnEDdgFVuuO2SGq9ElL+gQBRVwSc/2r0LOcpJLO+Kg8iciBKyfDY7F/4LS7yW lhbA== X-Gm-Message-State: APf1xPBrg+Ktoh6o/ei7fuHibPLaA1TAUg/uCPt4gNqGEAqvDJSz4GMg eUJHjFH7CwxmHRf57MvJWRA= X-Google-Smtp-Source: AH8x224IMHa3hBjzRU/Eo9NmGNb0GuhLAXTsyhhUDIKfUtA1xy39V5V2JHeogbA4PhAqwF7Snpdqyg== X-Received: by 10.55.3.66 with SMTP id 63mr8007198qkd.283.1519264628604; Wed, 21 Feb 2018 17:57:08 -0800 (PST) Received: from localhost.localdomain (50-39-100-161.bvtn.or.frontiernet.net. [50.39.100.161]) by smtp.gmail.com with ESMTPSA id n29sm14182630qtf.18.2018.02.21.17.57.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2018 17:57:08 -0800 (PST) From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Subject: [PATCH v12 14/22] selftests/vm: clear the bits in shadow reg when a pkey is freed. Date: Wed, 21 Feb 2018 17:55:33 -0800 Message-Id: <1519264541-7621-15-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1519264541-7621-1-git-send-email-linuxram@us.ibm.com> References: <1519264541-7621-1-git-send-email-linuxram@us.ibm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, ebiederm@xmission.com, arnd@arndb.de, linux-doc@vger.kernel.org, x86@kernel.org, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linuxram@us.ibm.com, mhocko@kernel.org, linux-mm@kvack.org, mingo@redhat.com, paulus@samba.org, aneesh.kumar@linux.vnet.ibm.com, bauerman@linux.vnet.ibm.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, khandual@linux.vnet.ibm.com Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" When a key is freed, the key is no more effective. Clear the bits corresponding to the pkey in the shadow register. Otherwise it will carry some spurious bits which can trigger false-positive asserts. cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index c4c73e6..e82bd88 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -586,7 +586,8 @@ int sys_pkey_free(unsigned long pkey) int ret = syscall(SYS_pkey_free, pkey); if (!ret) - shadow_pkey_reg &= reset_bits(pkey, PKEY_DISABLE_ACCESS); + shadow_pkey_reg &= reset_bits(pkey, + PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE); dprintf1("%s(pkey=%ld) syscall ret: %d\n", __func__, pkey, ret); return ret; }