From patchwork Mon Jan 15 23:16:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolin Chen X-Patchwork-Id: 861133 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zL8y85nyDz9sNc for ; Tue, 16 Jan 2018 10:41:36 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OvPft+Hz"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zL8y84W27zF0S6 for ; Tue, 16 Jan 2018 10:41:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OvPft+Hz"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c00::244; helo=mail-pf0-x244.google.com; envelope-from=nicoleotsuka@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OvPft+Hz"; dkim-atps=neutral Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zL8QQ13BDzF0Z7 for ; Tue, 16 Jan 2018 10:17:34 +1100 (AEDT) Received: by mail-pf0-x244.google.com with SMTP id y5so8745738pff.13 for ; Mon, 15 Jan 2018 15:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sR8B8z7IjNzHteHLGIt7SUVx/m1bx+Bf54+FDevnRDs=; b=OvPft+Hz0AukkcxyFQIuYsTJes+tLJgVKFWCvv3aCIXqxme6BvOymqXaUMzMVcZF9h foxGnVLP2c/QEipLfQHYMqU6qYgZEYnWoaDSU6p21mKgU6Ym+xYR8tsX4mMsrsLsM8d2 YPigqeisviW18ud1SpVzmA2FWR9Xae943bGPJ5aDJ4oYHzxHVTB0heIbbIXS3wm/vxP8 94xGKXX6PVPX0K7dEUgVnnhlnljoJrbGN0X6dtNIPGJ0/E3BXnUjRJlocWgIZ22eMXp1 04MmWk9qwHt89bDZW8V1UImsBsBn3tX3cSNbQFBMU0gMUdcjNvs/1PoBfEjyGpnAFZQz ladA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sR8B8z7IjNzHteHLGIt7SUVx/m1bx+Bf54+FDevnRDs=; b=gGYNMbQSkOgFUlwyPxLO/fL2Tlcryo6b9WmSsLxEiTkFDs0UaTCg7Y13zqX4Fnvgb4 6lSXBB5W4r8Icp1usaNtR/rKI8N5uimHAqF4i7VtNU2Z8WcwvKn1PGC3020yOP3oxqqO qsE/pQicbgSlhDZoAlzszJ5qVr0s5J75kA88erumq6PjRM7qW4pZ3UirxwJZtTfjCVFP WE6x+z3B0VzAZkh06D49lWX/SzVf0ygXqLxNpo2aQDp6RjgDYFVWvZ0BppHWeulCp6MU cmegCqyVDQg2/F3Ejvkxo3KmhuTkSdg7i9u/Ir6M1P8w3Z+7tBBA3E5o7MGmo5ipX0l4 JoCA== X-Gm-Message-State: AKwxytcfhIsPUgwVZI/xUMqi2TgHVPrJrOz3QVACtsixQbhRT3Xta3GV IvNR3p8fGDZaJE7C3Xu4h+I= X-Google-Smtp-Source: ACJfBotgSWvDm2xTWCpxj/WCxOvSYszwprZBbqK7/MeFcSRXGccX+LiMQ7qjp2GIsTaDEaY73i1rpQ== X-Received: by 10.99.126.73 with SMTP id o9mr10975894pgn.429.1516058251706; Mon, 15 Jan 2018 15:17:31 -0800 (PST) Received: from Asurada-CZ80.localdomain (c-73-231-2-134.hsd1.ca.comcast.net. [73.231.2.134]) by smtp.gmail.com with ESMTPSA id b6sm776442pfe.85.2018.01.15.15.17.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 15 Jan 2018 15:17:31 -0800 (PST) From: Nicolin Chen To: timur@tabi.org, broonie@kernel.org, mail@maciej.szmigiero.name Subject: [PATCH v4 09/17] ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals() Date: Mon, 15 Jan 2018 15:16:24 -0800 Message-Id: <1516058192-65519-10-git-send-email-nicoleotsuka@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516058192-65519-1-git-send-email-nicoleotsuka@gmail.com> References: <1516058192-65519-1-git-send-email-nicoleotsuka@gmail.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org, caleb@crome.org, lgirdwood@gmail.com, arnaud.mouiche@invoxia.com, lukma@denx.de, fabio.estevam@nxp.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" This patch cleans fsl_ssi_setup_regvals() by following changes: 1) Moving DBG bits to the first lines. 2) Setting SSIE, RE/TE as default and cleaning it for AC97 Signed-off-by: Nicolin Chen Tested-by: Caleb Crome --- sound/soc/fsl/fsl_ssi.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index b76a517..e5efee2 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -580,18 +580,16 @@ static void fsl_ssi_setup_regvals(struct fsl_ssi *ssi) { struct fsl_ssi_regvals *vals = ssi->regvals; - vals[RX].sier = SSI_SIER_RFF0_EN; + vals[RX].sier = SSI_SIER_RFF0_EN | FSLSSI_SIER_DBG_RX_FLAGS; vals[RX].srcr = SSI_SRCR_RFEN0; - vals[RX].scr = 0; - vals[TX].sier = SSI_SIER_TFE0_EN; + vals[RX].scr = SSI_SCR_SSIEN | SSI_SCR_RE; + vals[TX].sier = SSI_SIER_TFE0_EN | FSLSSI_SIER_DBG_TX_FLAGS; vals[TX].stcr = SSI_STCR_TFEN0; - vals[TX].scr = 0; + vals[TX].scr = SSI_SCR_SSIEN | SSI_SCR_TE; /* AC97 has already enabled SSIEN, RE and TE, so ignore them */ - if (!fsl_ssi_is_ac97(ssi)) { - vals[RX].scr = SSI_SCR_SSIEN | SSI_SCR_RE; - vals[TX].scr = SSI_SCR_SSIEN | SSI_SCR_TE; - } + if (fsl_ssi_is_ac97(ssi)) + vals[RX].scr = vals[TX].scr = 0; if (ssi->use_dma) { vals[RX].sier |= SSI_SIER_RDMAE; @@ -600,9 +598,6 @@ static void fsl_ssi_setup_regvals(struct fsl_ssi *ssi) vals[RX].sier |= SSI_SIER_RIE; vals[TX].sier |= SSI_SIER_TIE; } - - vals[RX].sier |= FSLSSI_SIER_DBG_RX_FLAGS; - vals[TX].sier |= FSLSSI_SIER_DBG_TX_FLAGS; } static void fsl_ssi_setup_ac97(struct fsl_ssi *ssi)