From patchwork Sun Sep 24 17:30:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 817953 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y0Z6m5G0Fz9sCZ for ; Mon, 25 Sep 2017 03:32:48 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EfmGZ1ZV"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3y0Z6m3lYdzDsMC for ; Mon, 25 Sep 2017 03:32:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EfmGZ1ZV"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c05::241; helo=mail-pg0-x241.google.com; envelope-from=groeck7@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EfmGZ1ZV"; dkim-atps=neutral Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3y0Z4S5lT5zDqNh for ; Mon, 25 Sep 2017 03:30:48 +1000 (AEST) Received: by mail-pg0-x241.google.com with SMTP id u18so3659711pgo.1 for ; Sun, 24 Sep 2017 10:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=3XKiluf8/Ri+ynXc1uNuGfVX7SXoxloR/urrOSmFEfc=; b=EfmGZ1ZVr8Sr+c1naxLcLMbHQMgrxiKFAsCMeefoUSZknhznggy9Yl+CQ23bcWnwrT P83im5XbtZ5k44c+lj4vNSZrx/cWO68RKnXj/+3wmvpuPowK4Kdvezbva7N0ZKg/1B0r bcsM6iDCDq0wAWGmkgQF0VHpcQ2vGy5OxXzKSmVvPt1xMPj4l3n5DV13w0NC5DBSLjiA ss3cygnWZo4v6WNINLDai1vH0DBgAX5S96nco+OLH0pNSTsdE0Dy1Xy8Z+zgBxwzctky X9f1M6auNlgwogsLsheI136prkuEX34Gr1m9iPlR8lonpshARZEkExhHHQGItWMCqRmt Pozw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=3XKiluf8/Ri+ynXc1uNuGfVX7SXoxloR/urrOSmFEfc=; b=MyHkHGOGf9zKwbVIxkdZWS1u0M9tmDnC2sk69EzXSsuaaqwrxaNLas6283WYaS6L2D 9UAoOlD5BHm8EPlbLtB/je9cjdmj5wksbsm3/svhdF8hBc7Vfu5LV2ehdWpjpZkYcXPk J+0gTVqcO+0CL09Fyk1EAXBJNkF9YeYa7yJUoRJNlPdDi2dxrm17dTD9++0WZpH4638Q wv8T95wGftwrN5Z3wW3ZRiTxVgPZeEPkUxn0bOLFHWxABXa119aPPAcVTCz4InUkEw9C WfOTOe1DX76uL/5Na3uRSIlgOXKIroYhdsaRDCW5K9j29YW5Z6RKkPA/qaHvWk5EbEWb 4bbA== X-Gm-Message-State: AHPjjUitoQ8+M6kvtMDsKumg/I9pL5pPs2lz9KcClmzMubvok4TN9jvp V7dVOvmIQRgix+OYVKAiOgQ= X-Google-Smtp-Source: AOwi7QC4BNCU3luVzG4ZkVb8Gk6M1hgepDWo5CEwdgaHluRvJDjzcgBzeTnkKyhAHdErx0sCb1XNsQ== X-Received: by 10.99.132.199 with SMTP id k190mr5294413pgd.25.1506274246262; Sun, 24 Sep 2017 10:30:46 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id s68sm8917331pfd.72.2017.09.24.10.30.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Sep 2017 10:30:45 -0700 (PDT) From: Guenter Roeck To: Benjamin Herrenschmidt Subject: [PATCH] powerpc/mm: Call flush_tlb_kernel_range with interrupts enabled Date: Sun, 24 Sep 2017 10:30:43 -0700 Message-Id: <1506274243-28540-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Guenter Roeck Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" flush_tlb_kernel_range() may call smp_call_function_many() which expects interrupts to be enabled. This results in a traceback. WARNING: CPU: 0 PID: 1 at kernel/smp.c:416 smp_call_function_many+0xcc/0x2fc CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.14.0-rc1-00009-g0666f56 #1 task: cf830000 task.stack: cf82e000 NIP: c00a93c8 LR: c00a9634 CTR: 00000001 REGS: cf82fde0 TRAP: 0700 Not tainted (4.14.0-rc1-00009-g0666f56) MSR: 00021000 CR: 24000082 XER: 00000000 GPR00: c00a9634 cf82fe90 cf830000 c050ad3c c0015a54 00000000 00000001 00000001 GPR08: 00000001 00000000 00000000 cf82e000 24000084 00000000 c0003150 00000000 GPR16: 00000000 00000000 00000000 00000000 00000000 00000001 00000000 c0510000 GPR24: 00000000 c0015a54 00000000 c050ad3c c051823c c050ad3c 00000025 00000000 NIP [c00a93c8] smp_call_function_many+0xcc/0x2fc LR [c00a9634] smp_call_function+0x3c/0x50 Call Trace: [cf82fe90] [00000010] 0x10 (unreliable) [cf82fed0] [c00a9634] smp_call_function+0x3c/0x50 [cf82fee0] [c0015d2c] flush_tlb_kernel_range+0x20/0x38 [cf82fef0] [c001524c] mark_initmem_nx+0x154/0x16c [cf82ff20] [c001484c] free_initmem+0x20/0x4c [cf82ff30] [c000316c] kernel_init+0x1c/0x108 [cf82ff40] [c000f3a8] ret_from_kernel_thread+0x5c/0x64 Instruction dump: 7c0803a6 7d808120 38210040 4e800020 3d20c052 812981a0 2f890000 40beffac 3d20c051 8929ac64 2f890000 40beff9c <0fe00000> 4bffff94 7fc3f378 7f64db78 Fixes: 3184cc4b6f6a ("powerpc/mm: Fix kernel RAM protection after freeing ...") Fixes: e611939fc8ec ("powerpc/mm: Ensure change_page_attr() doesn't ...") Cc: Christophe Leroy Signed-off-by: Guenter Roeck Reviewed-by: Christophe Leroy --- arch/powerpc/mm/pgtable_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c index 65eda1997c3f..f6c7f54c0515 100644 --- a/arch/powerpc/mm/pgtable_32.c +++ b/arch/powerpc/mm/pgtable_32.c @@ -361,9 +361,9 @@ static int change_page_attr(struct page *page, int numpages, pgprot_t prot) break; } wmb(); + local_irq_restore(flags); flush_tlb_kernel_range((unsigned long)page_address(start), (unsigned long)page_address(page)); - local_irq_restore(flags); return err; }