diff mbox

[v7,01/11] powerpc: move set_soft_enabled() and rename

Message ID 1491984040-28801-2-git-send-email-maddy@linux.vnet.ibm.com (mailing list archive)
State Superseded
Headers show

Commit Message

maddy April 12, 2017, 8 a.m. UTC 
Move set_soft_enabled() from powerpc/kernel/irq.c to
asm/hw_irq.c, to force updates to paca-soft_enabled
done via these access function. Add "memory" clobber
to hint compiler since paca->soft_enabled memory is the target
here

Renaming it as soft_enabled_set() will make
namespaces works better as prefix than a postfix
when new soft_enabled manipulation functions introduced.

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
 arch/powerpc/include/asm/hw_irq.h | 15 +++++++++++++++
 arch/powerpc/kernel/irq.c         | 12 +++---------
 2 files changed, 18 insertions(+), 9 deletions(-)

Comments

Michael Ellerman April 13, 2017, 10:54 p.m. UTC | #1 
Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes:
> @@ -269,7 +263,7 @@ notrace void arch_local_irq_restore(unsigned long en)
>  	replay = __check_irq_replay();
>  
>  	/* We can soft-enable now */
> -	set_soft_enabled(IRQ_DISABLE_MASK_NONE);
> +	soft_enabled_set(IRQ_DISABLE_MASK_NONE);

In upstream we don't have any of the IRQ_DISABLE_MASK_* flags.

So something's gotten a bit messed up here, did you forget to send a
patch, or are they out of order or something?

I spent 10 minutes with quilt trying to massage it but pretty much every
patch seems to be patching code that I don't have.

cheers
maddy April 17, 2017, 1:15 a.m. UTC | #2 
On Friday 14 April 2017 04:24 AM, Michael Ellerman wrote:
> Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes:
>> @@ -269,7 +263,7 @@ notrace void arch_local_irq_restore(unsigned long en)
>>   	replay = __check_irq_replay();
>>   
>>   	/* We can soft-enable now */
>> -	set_soft_enabled(IRQ_DISABLE_MASK_NONE);
>> +	soft_enabled_set(IRQ_DISABLE_MASK_NONE);
> In upstream we don't have any of the IRQ_DISABLE_MASK_* flags.
>
> So something's gotten a bit messed up here, did you forget to send a
> patch, or are they out of order or something?

Oops. Yes i missed the first patch in the series.
Missed at format-patch step. My bad

>
> I spent 10 minutes with quilt trying to massage it but pretty much every
> patch seems to be patching code that I don't have.

Sorry. Will resend as v8.
Maddy

> cheers
>
diff mbox

Patch

diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h
index 05b81bca15e9..ab1e6da7825c 100644
--- a/arch/powerpc/include/asm/hw_irq.h
+++ b/arch/powerpc/include/asm/hw_irq.h
@@ -47,6 +47,21 @@  extern void unknown_exception(struct pt_regs *regs);
 #ifdef CONFIG_PPC64
 #include <asm/paca.h>
 
+/*
+ *TODO:
+ * Currently none of the soft_eanbled modification helpers have clobbers
+ * for modifying the r13->soft_enabled memory itself. Secondly they only
+ * include "memory" clobber as a hint. Ideally, if all the accesses to
+ * soft_enabled go via these helpers, we could avoid the "memory" clobber.
+ * Former could be taken care by having location in the constraints.
+ */
+static inline notrace void soft_enabled_set(unsigned long enable)
+{
+	__asm__ __volatile__("stb %0,%1(13)"
+	: : "r" (enable), "i" (offsetof(struct paca_struct, soft_enabled))
+	: "memory");
+}
+
 static inline unsigned long arch_local_save_flags(void)
 {
 	unsigned long flags;
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index 60c15fb05f45..a856e0fed7b6 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -108,12 +108,6 @@  static inline notrace unsigned long get_irq_happened(void)
 	return happened;
 }
 
-static inline notrace void set_soft_enabled(unsigned long enable)
-{
-	__asm__ __volatile__("stb %0,%1(13)"
-	: : "r" (enable), "i" (offsetof(struct paca_struct, soft_enabled)));
-}
-
 static inline notrace int decrementer_check_overflow(void)
 {
  	u64 now = get_tb_or_rtc();
@@ -213,7 +207,7 @@  notrace void arch_local_irq_restore(unsigned long en)
 	unsigned int replay;
 
 	/* Write the new soft-enabled value */
-	set_soft_enabled(en);
+	soft_enabled_set(en);
 	if (en == IRQ_DISABLE_MASK_LINUX)
 		return;
 	/*
@@ -259,7 +253,7 @@  notrace void arch_local_irq_restore(unsigned long en)
 	}
 #endif /* CONFIG_TRACE_IRQFLAGS */
 
-	set_soft_enabled(IRQ_DISABLE_MASK_LINUX);
+	soft_enabled_set(IRQ_DISABLE_MASK_LINUX);
 
 	/*
 	 * Check if anything needs to be re-emitted. We haven't
@@ -269,7 +263,7 @@  notrace void arch_local_irq_restore(unsigned long en)
 	replay = __check_irq_replay();
 
 	/* We can soft-enable now */
-	set_soft_enabled(IRQ_DISABLE_MASK_NONE);
+	soft_enabled_set(IRQ_DISABLE_MASK_NONE);
 
 	/*
 	 * And replay if we have to. This will return with interrupts