From patchwork Wed Nov 16 14:40:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Manoil X-Patchwork-Id: 695628 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tJnHT5Dctz9t0w for ; Thu, 17 Nov 2016 01:50:29 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tJnHT4TkXzDvpK for ; Thu, 17 Nov 2016 01:50:29 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0062.outbound.protection.outlook.com [104.47.42.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tJn4L3svZzDvmd for ; Thu, 17 Nov 2016 01:40:50 +1100 (AEDT) Received: from DM2PR03CA0050.namprd03.prod.outlook.com (10.141.96.49) by BY2PR0301MB0742.namprd03.prod.outlook.com (10.160.63.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.721.10; Wed, 16 Nov 2016 14:40:44 +0000 Received: from BN1AFFO11FD048.protection.gbl (2a01:111:f400:7c10::116) by DM2PR03CA0050.outlook.office365.com (2a01:111:e400:2428::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.721.10 via Frontend Transport; Wed, 16 Nov 2016 14:40:43 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD048.mail.protection.outlook.com (10.58.53.63) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.721.5 via Frontend Transport; Wed, 16 Nov 2016 14:40:42 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:; UpperCasedChecksum:; SizeAsReceived:727; Count:10 Received: from fsr-fed1764-016.ea.freescale.net (fsr-fed1764-016.ea.freescale.net [10.171.81.161]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uAGEeVKZ005542; Wed, 16 Nov 2016 07:40:41 -0700 From: Claudiu Manoil To: Subject: [PATCH 06/17] soc/qman: Fix direct access to fd's addr_lo, use proper accesor Date: Wed, 16 Nov 2016 16:40:19 +0200 Message-ID: <1479307230-16650-7-git-send-email-claudiu.manoil@nxp.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1479307230-16650-1-git-send-email-claudiu.manoil@nxp.com> References: <1479307230-16650-1-git-send-email-claudiu.manoil@nxp.com> X-IncomingHeaderCount: 10 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131237808431992597; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(336004)(339900001)(199003)(189002)(33646002)(6916009)(4720700003)(87936001)(6666003)(2950100002)(81156014)(626004)(50466002)(36756003)(48376002)(76176999)(50986999)(97736004)(92566002)(2906002)(81166006)(85426001)(105606002)(575784001)(77096005)(50226002)(8936002)(47776003)(86362001)(110136003)(106466001)(4326007)(305945005)(189998001)(7846002)(68736007)(5660300001)(2351001)(8676002)(69596002)(356003)(5003940100001)(8666005)(104016004)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB0742; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD048; 1:0evGZ2PFMMyupm51CeLAnSXLMpIJ/fWq/0Kv3rFz6vOqwOyDbKBrAGwDCDXY5hwY27BMhZHTS1fEPwAIfy+pTX1so5Ow9+659AfJdOGVs2GDIi2uYHgX5ufO54fzLxwmcVO+ESih21Jec0+EBRMxc0KCX3lQ4pj8udeL8SYDgXLpnnkKFvLO93hiFo7xgN8jjtjNrUcNDPl8MYq6+ZhZ+KhGagYZO8TeHdXIDHlOvFnW79xi2BZZQ1juteWBgkM0i5uW62FiV053g425fkDw9wwvbycE1wbg3iZFVnY65BkUlGKW9mnk09+Y7uMxLJLB3btFQryZFrMUX7kMxmUFQTX3xmnj9W0LtZgSM+ke61BILIyv5we2TRYiC67h1TjCliHsZs00uCuFYP9bDjubaPHlognpMpjT9t2hhjyoxd1nEHAeK/Mdv3saN3CvtJIPwuJ6g2b9vtPMcccP/Ar5C71qAP2CIhAxuhR1FsEIfS5mssqNYkOeJDzjkNtE2GnSO43zVFM7hjmLWjCITBrpH6lBaZi/xLesc2jA9B+AFmkJhLoYZb8ZJkdU7/dYkiVrQUaoCoK9HBStEEf4REadIhWZKD2fHBuP9F5fkCFkr4iiu0g3+vWSwDwac+hsEj95WxDIZO3XcDb1kxcQvLnIupRBm6hFprmV6HOfK9OEd1dfdsrgZyMxjPjxJoLoJsC4iwxx0gK2A/c5NgdXGTto8A1Dhx7MQjRnXHiT7WD8rSo= MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0742; 2:nBxvU3ZICoKYmoNGzDIfXSi0SQsc7ag9A89jWytZ0dMtKHAOwyEaS0WzNaQ/ZearZxzHwY+9qoXHNSRKVPKqMdDSHzfxEkLuWlNObTUWjJL28hBHLTTGlVONU73ZNg4Ln569v5blb1g47MZZC+j4SJiTIz1l3l6lh51Z9mlwhxE=; 3:rOr0fJMYhjILq9C5w0Je7+syG7a9Usek66pXZcLkCyhDSCb/VNXj0IWbIO+y+/XQkjx8LI6CcIRe/oDWe7860rsIcSmTkXSdbFNpPTVfYhHoZjmXYO1J9PEX3SnZ15kp9o9V4mDnjkFCF9T5qXvVtFHifCwqKkDl1ZOEi0rcrSlQah5ZUn7xNVyEz/syvDLPIGdZNeGYv2xY55apGbw+3fi1F7MRV8Gt5zrDSsDfc9ntT5WGnHOP5qwCpgMZkLakG233G8GvWCgIpYZR3mpcsQ==; 25:Q0wXLiUo2xUxdYzki6DcHrcQuJDwRmoD/SINS5+cTLUgHJvvT3WXGEPFUDNpihbBwzH0ixxtrjWnnoimcBfUFO7oW/ibHv87lW604EVBZ61UR6t02UoQOW/F6yvWMZd/j6ruk+zKSK809anPMHwvnd+FOzLAdZ+xa+grBGeukCGZlrGy/4iJecLjU1FrXwEriAwK6UpPi0FBloS2xl3HQ8tuR/N4KwzcLU2ckqMACNBI2la2rNHeshhAqn6rSebVWbvCzmB92PMXuMW9e1Us9R9j4d3ZchGa7lgkFhl+kSIg1uyZMOXb06hPzFMrN05RH8ripmrVx9rAdXCQ/f1DJcpULVhnzDbK9dmWYKH6bYBRkHcbnf4H5DNgqUvs7Hi+DRuQsLBLx2s5xi6Jgw1FTKNCumAhnVSCn4/fPjfC9DQgCFsYi7ZWz10Q/IXNdB6sm6EnOWZspmP8i2+qBys0Ow== X-MS-Office365-Filtering-Correlation-Id: 228f3e7e-e464-46ee-2db7-08d40e2e8b25 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR0301MB0742; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0742; 31:zXTYzisB6WpOsGmRJk2RcMn6IiLUqLH61FFM4YEBLbGzI23E0rodhrqsE8lMa/PeXQmBM3wJjw2H51cOSqUOoY8I6Jn6fmIXgFRBADxUSW7lipMMlZNz3KQby1XUkkUu1u2FYNHHYueXrwMtfbNWTaph93hQI37/qCeneddV7Gx/fgRKen0SVzbjugBlacWU0qqJZcxfrgiJNB2GZGx4d62gB6FySfB7vjzY1wkbUv/OQZG8SpHV5fJitDwN/M2Q8tN1mWz0vuCxG08oM2hpdQ==; 4:J4LUtZYBAuC0WFaMB7Jk9MFUJebgmGPQYnqwU5oojKvQX1cDIP2+oYHFO8FcRJzvMTkrWLXbjk5cLpxT5hIdZUlIYOBFWoQ0YVqMNyQcIu29MPWXPHooRKlfWjso2NQy61IGLWqaphMazULPXYN0U/BE6/17UwW/UftvjpKCrV2AaDK+8I9374HmEGu6/jfLlsvf+YvSZBqjHzHzchpHb6YoIG6PT7iYqKNKSHwjf6Dk6csU90HwaQ9IV8OGDrOD+433r7mj3ZxCm+eIkF/ortkYZl0VK2tdExDFe8E2jEGOgYT2jlLmZnWjA2XxfoUfr2h4Mdv9QIqFEevdncdCw0VB9QVmaCUx5oGq5LxDIfEuXoRJMRUMhT9eoAKDa7935uT5f1Lt/0aM9CNtQyc4vI41iE1SHt1r1ypWNt25jhoUKhS9HzyovbpefmqhA2kneQCM3i9qH7bf1MHqeGa+zmFJf4zm/OVtIYjqI4Wwf5VyExLhbgbRtacet9EBg9dHKC0U+QIPdfla/wcVdstqs+mz3C2BkO07eiQQxLAtZCBca3gz+K8foymVosfNDNdzzctZvWA9AL3HEiT1q7tXWA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095035)(601004)(2401047)(5005006)(13024025)(13015025)(13018025)(13023025)(8121501046)(13017025)(10201501046)(3002001)(6055026)(6096035); SRVR:BY2PR0301MB0742; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB0742; X-Forefront-PRVS: 01283822F8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0301MB0742; 23:Jt20RJnLvmMkdKYKpO0NkIaDeYAQMZwcciKyyJZ?= =?us-ascii?Q?NgiUH7DVfKtPEHzpgPh4la7YHi6wqZtPVwbjyDJD3mmvz4fHn3wIAVomN5Gz?= =?us-ascii?Q?ky49qvJKtldXu21K4SsiEPZXu/t1CeieINtoMuoqBxGylWfLvEHrVy3eZSgZ?= =?us-ascii?Q?e3U38ijjPUiNE6RmU9D3QSa97GUCW6t0rIl1+0GnKbJZTfoK17LmpjdToRlM?= =?us-ascii?Q?SJQslO8JxvqH7G8lAWOjnl6jrYUysxlcVzVuzp2c+zExwxmv6Jp5vCQm4b4K?= =?us-ascii?Q?FeYhh8/ldCvB5pJBhocsdI86ffw7YYfpoQQ3EhxHo1JbU8ak8DTuDABlGX0V?= =?us-ascii?Q?Rxh8jtmH/uYVYUAwYvp3XUZ4L/QnnEWPx7eGv4RaAkbVzFlTDmaMVXje5fDC?= =?us-ascii?Q?Neymo1VQ4qLoFUZD2nTih8ybFBljvQKHQbgF3yKF0c8rZbnNiK+0Gkmdboa1?= =?us-ascii?Q?DhRdfqqVCFfoSLLUuPuA2vOpkh0TY+0SVhqL2lF9WCLCYmDIQzchbCm00Q7l?= =?us-ascii?Q?F/39Ohx7Piuv6a3LZsY7yaDBU64NvQQAFd77UK94hPjwiBNxMvpX0z9zyQMq?= =?us-ascii?Q?6qeC4hPsQTlgbsX7ayn1t0mhEq/64ZYbwv9f1GXBjkz9MiSWHFAGecB4E7MV?= =?us-ascii?Q?zTArP0Q0fmDtGjuN70awGlvEEiN3y1s/ePbT7dlzyNO0OjMcGZ8f6jzvd24V?= =?us-ascii?Q?41J71sBvnlmVOhMdAe9lE3iwaAzqNt+p1Ea8nYE8hZMSF11Uwj/wIdgEY29B?= =?us-ascii?Q?2DloYMXFz0B4f3wALMrVwbV3GUscxqgNl6OmmrD+aoBYj13Px+PF0ubaVlv+?= =?us-ascii?Q?wMmxBJQvNEfBbmdU8DVjT4+mFYDzNTiUTNq79cN2RZHbAiKowEnbPPcK3s3Z?= =?us-ascii?Q?xQvxZApPNQoCY58wy4CWXkwcsQIYnPDAzNzXOLcSs7O0QWI1xazdLVE0bHON?= =?us-ascii?Q?mk6uU2E6nca6SbjJsdcgqJYt9yOUxT8vmRmjGp4IW7q1wfbSCSawScIULQHe?= =?us-ascii?Q?iPEBlEIkh2dUa3DGfFadlG488DcRd8C6icfBAR4H14e4T5LaOV3soOsckn6s?= =?us-ascii?Q?WJA7uApm4Xv84sw/sX2v/3Z8et2jefAj8jw2W7NhUP7BfwuNf+fjEno1nCPy?= =?us-ascii?Q?cHwTyIa0DtcHniV+LM7Jo3mw4IiyvEY2/OjuHd39vrCJxfTl1kZSX8Ocl86W?= =?us-ascii?Q?i9iF3dw7/zYWySsQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0742; 6:bklT6MDTYQBpfvUoF1KZgSX5u69BsVVtDU6sksIP6yXeia14oX9tUr8ufRgdpKEVxpuTmktkCIbJ3Hmz9Jz+2NJRO6TIR8PVbMgJeAhkrugVNFl+jvwc2BOHO91VqfdSdRfZkW1UpquDsv7RAqgVKHIVUurSVL/CU7ULMJ8Zec3pbg0wkymlx31+EM+oQT+TrHv/USPFTsMHrtO0mqFpBdIlsugz60+abQYuo2TKCnqZiVG/JVdhyzI+COmjunpwGdo+N6qLmnCOEdRxmSZycjaXyB+cXFt0UjeslE1X6osyuNxpF6pVqu/2K5R8wAsH8GVcHQIyoGD/3zFCIEg+DA==; 5:CW9/8bJuNK1C+qC67gaLMfWosCCgPfzAkZTyleJedBxOWhbWLlHinTqO1Ab/irRPecmKnsukYjRQ7NhH8AS0W57ez2pzCUB/0lQZ5obCxVtyzOwk5RGeMyjS3mQAbXvzsfcjCi8KwWEHBGn6vBxEmBpNuDoE0GgPXQteyG2lxF3cKU4n+4eCH75wx3RxHbG9; 24:27mIzYr8zSM8wjdEPdMnGiaYKQFMugORu0nRBqQ0Boq92LArwKeUzN6Ay4eZW7w6NfscEMq9fri4xfl3W1u+eL75KtnfexzqR0CLqf96BZc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0742; 7:D0gs24AwrrRdaoONTsABpwHAgKY46scc1T17RWVu/JHq53v9G/zvURg3kPuToyj7vj8vgtYL05N1gauDEBPblm+Af7s5e3npXgxx9Ykbbv/6bSBc21+b25EnS5HhSbBTwVNT+1pDXYLevHG9BzOVZjy4+1IhpgKlBngv/n3NkU3dd5C+eK0s+iVeIlcLRpx7ZZXktQpEjZEuM2MzwyKn74FYsEFtSvzi+mE6K3LGF1lkNwOf22EnQxJ5EmBqioTdGRiEcLlX/t9sDsrS0XYwBSMdBUYjtNilHKWwuKscB4o96MqY38xTf8H8NN85dFigU0KKblYTnm8imWeFdn4iA/K8t9IhCfTGFcsXu/4QOLw= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2016 14:40:42.9496 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0742 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Wood , roy.pledge@nxp.com Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Use the proper accessor to get the FD address. Accessing the internal field "addr_lo" directly is not portable and error prone. Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c index 80ff0b7..b4ef4a3 100644 --- a/drivers/soc/fsl/qbman/qman.c +++ b/drivers/soc/fsl/qbman/qman.c @@ -1239,8 +1239,8 @@ static int qman_create_portal(struct qman_portal *portal, /* special handling, drain just in case it's a few FQRNIs */ const union qm_mr_entry *e = qm_mr_current(p); - dev_err(c->dev, "MR dirty, VB 0x%x, rc 0x%x\n, addr 0x%x", - e->verb, e->ern.rc, e->ern.fd.addr_lo); + dev_err(c->dev, "MR dirty, VB 0x%x, rc 0x%x, addr 0x%llx\n", + e->verb, e->ern.rc, qm_fd_addr_get64(&e->ern.fd)); goto fail_dqrr_mr_empty; } /* Success */