From patchwork Wed Aug 17 10:03:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 660039 X-Patchwork-Delegate: benh@kernel.crashing.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sDlSv45wTz9rvt for ; Wed, 17 Aug 2016 20:14:23 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3sDlSv3HZbzDr87 for ; Wed, 17 Aug 2016 20:14:23 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org X-Greylist: delayed 604 seconds by postgrey-1.35 at bilbo; Wed, 17 Aug 2016 20:13:22 AEST Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3sDlRk5K9qzDr4d for ; Wed, 17 Aug 2016 20:13:22 +1000 (AEST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OC1009LRT9BQQ80@mailout4.w1.samsung.com> for linuxppc-dev@lists.ozlabs.org; Wed, 17 Aug 2016 11:03:12 +0100 (BST) X-AuditID: cbfec7f4-f796c6d000001486-91-57b4365f7ea1 Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id F5.35.05254.F5634B75; Wed, 17 Aug 2016 11:03:11 +0100 (BST) Received: from amdc1061.digital.local ([106.116.147.88]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OC100BSCT9BHQ30@eusync2.samsung.com>; Wed, 17 Aug 2016 11:03:11 +0100 (BST) From: Andrzej Hajda To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)) Subject: [PATCH] powerpc/powernv/pci: fix iterator signedness Date: Wed, 17 Aug 2016 12:03:05 +0200 Message-id: <1471428185-23529-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnluLIzCtJLcpLzFFi42I5/e/4Fd14sy3hBn9mWFjcWneO1WLjjPWs Fh+aWpktLu+aw2bx+/s/Vou1R+6yW2xpOMRmsebIYnYHDo9FLxtYPHretLB6nJ+xkNFj7q4+ Ro++LasYPT5vkgtgi+KySUnNySxLLdK3S+DKWPT5EnvBFvaK6ZcsGhiXsnUxcnJICJhITJ37 lAXCFpO4cG89UJyLQ0hgKaPEgo5ZTBBOE5PEvFdPwKrYBDQl/m6+CVYlInCFUeL66X+sIA6z wC5GiT831zKDVAkL2EpMPXKQCcRmEVCV+LjuIZjNK+As8aFvH9Q+OYmTxyazTmDkXsDIsIpR NLU0uaA4KT3XUK84Mbe4NC9dLzk/dxMjJHi+7GBcfMzqEKMAB6MSD+9Nq83hQqyJZcWVuYcY JTiYlUR4p5psCRfiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3fX+xAhgfTEktTs1NSC1CKYLBMH p1QD4xQ/T+95O2sXtT1Wd13gs3SNt0HrmYWxcbcvdSxaem8+x/q25tCXBcfW71hvZRsv9DA2 stew/YPx9sV/HDxC/hbXVCTH/Fx3uencVGHXHzLX/beulP606PzBinpu3coHlbPNPlt9/uq4 yCD9qubvK9Y2amtlu8sOmeq8mdP4y6JT0lz36IEfPEosxRmJhlrMRcWJAJPXudQaAgAA X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrzej Hajda , Marek Szyprowski , open list , Bartlomiej Zolnierkiewicz Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Unsigned type is always non-negative, so the loop could not end in case condition is never true. The problem has been detected using semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci Signed-off-by: Andrzej Hajda --- arch/powerpc/platforms/powernv/pci-ioda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c index fd9444f..1321826 100644 --- a/arch/powerpc/platforms/powernv/pci-ioda.c +++ b/arch/powerpc/platforms/powernv/pci-ioda.c @@ -149,7 +149,7 @@ static void pnv_ioda_reserve_pe(struct pnv_phb *phb, int pe_no) static struct pnv_ioda_pe *pnv_ioda_alloc_pe(struct pnv_phb *phb) { - unsigned long pe = phb->ioda.total_pe_num - 1; + long pe; for (pe = phb->ioda.total_pe_num - 1; pe >= 0; pe--) { if (!test_and_set_bit(pe, phb->ioda.pe_alloc))