| Message ID | 1464847803-22756-3-git-send-email-xyjxie@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi,
[auto build test ERROR on vfio/next]
[also build test ERROR on v4.7-rc1 next-20160603]
[cannot apply to pci/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Yongji-Xie/PCI-Add-a-new-PCI_BUS_FLAGS_MSI_REMAP-flag/20160530-215348
base: https://github.com/awilliam/linux-vfio.git next
config: arm-sa1100 (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/built-in.o: In function `pci_set_bus_msi_domain':
>> arm_pmu.c:(.text+0x5c58): undefined reference to `pci_bus_msi_isolated'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi,
[auto build test ERROR on vfio/next]
[also build test ERROR on v4.7-rc1 next-20160603]
[cannot apply to pci/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Yongji-Xie/PCI-Add-a-new-PCI_BUS_FLAGS_MSI_REMAP-flag/20160530-215348
base: https://github.com/awilliam/linux-vfio.git next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/pci/msi.c: In function 'pci_bus_msi_isolated':
>> drivers/pci/msi.c:1146:20: error: 'MSI_FLAG_IRQ_REMAPPING' undeclared (first use in this function)
if (info->flags & MSI_FLAG_IRQ_REMAPPING)
^
drivers/pci/msi.c:1146:20: note: each undeclared identifier is reported only once for each function it appears in
vim +/MSI_FLAG_IRQ_REMAPPING +1146 drivers/pci/msi.c
1140 struct msi_domain_info *info;
1141
1142 if (!domain)
1143 return 0;
1144
1145 info = msi_get_domain_info(domain);
> 1146 if (info->flags & MSI_FLAG_IRQ_REMAPPING)
1147 return 1;
1148 #endif
1149 return 0;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
On 2016/6/6 4:10, kbuild test robot wrote: > Hi, > > [auto build test ERROR on vfio/next] > [also build test ERROR on v4.7-rc1 next-20160603] > [cannot apply to pci/next] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Yongji-Xie/PCI-Add-a-new-PCI_BUS_FLAGS_MSI_REMAP-flag/20160530-215348 > base: https://github.com/awilliam/linux-vfio.git next > config: arm-sa1100 (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > > drivers/built-in.o: In function `pci_set_bus_msi_domain': >>> arm_pmu.c:(.text+0x5c58): undefined reference to `pci_bus_msi_isolated' Sorry for this fault. I will fix it in next version. The pci_bus_msi_isolated() should not depend on CONFIG_PCI_MSI, I would move this function from drivers/pci/msi.c to drivers/pci/probe.c. Thanks, Yongji
On 2016/6/6 5:11, kbuild test robot wrote: > Hi, > > [auto build test ERROR on vfio/next] > [also build test ERROR on v4.7-rc1 next-20160603] > [cannot apply to pci/next] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Yongji-Xie/PCI-Add-a-new-PCI_BUS_FLAGS_MSI_REMAP-flag/20160530-215348 > base: https://github.com/awilliam/linux-vfio.git next > config: arm-allmodconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > > drivers/pci/msi.c: In function 'pci_bus_msi_isolated': >>> drivers/pci/msi.c:1146:20: error: 'MSI_FLAG_IRQ_REMAPPING' undeclared (first use in this function) > if (info->flags & MSI_FLAG_IRQ_REMAPPING) > ^ > drivers/pci/msi.c:1146:20: note: each undeclared identifier is reported only once for each function it appears in > > vim +/MSI_FLAG_IRQ_REMAPPING +1146 drivers/pci/msi.c > > 1140 struct msi_domain_info *info; > 1141 > 1142 if (!domain) > 1143 return 0; > 1144 > 1145 info = msi_get_domain_info(domain); >> 1146 if (info->flags & MSI_FLAG_IRQ_REMAPPING) > 1147 return 1; > 1148 #endif > 1149 return 0; This fault is expected because this patch is based on patchset [1] which introduce flag MSI_FLAG_IRQ_REMAPPING. [1] https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1138820.html Thanks, Yongji
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index a080f44..dbdb5c3 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -1134,6 +1134,21 @@ void *msi_desc_to_pci_sysdata(struct msi_desc *desc) } EXPORT_SYMBOL_GPL(msi_desc_to_pci_sysdata); +int pci_bus_msi_isolated(struct pci_bus *bus, struct irq_domain *domain) +{ +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN + struct msi_domain_info *info; + + if (!domain) + return 0; + + info = msi_get_domain_info(domain); + if (info->flags & MSI_FLAG_IRQ_REMAPPING) + return 1; +#endif + return 0; +} + #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN /** * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 8004f67..2b9e3ba 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -713,6 +713,9 @@ static void pci_set_bus_msi_domain(struct pci_bus *bus) if (!d) d = pci_host_bridge_msi_domain(b); + if (b == bus && pci_bus_msi_isolated(bus, d)) + bus->bus_flags |= PCI_BUS_FLAGS_MSI_REMAP; + dev_set_msi_domain(&bus->dev, d); } diff --git a/include/linux/msi.h b/include/linux/msi.h index 08441b1..04cc749 100644 --- a/include/linux/msi.h +++ b/include/linux/msi.h @@ -15,6 +15,8 @@ extern int pci_msi_ignore_mask; struct irq_data; struct msi_desc; struct pci_dev; +struct pci_bus; +struct irq_domain; struct platform_msi_priv_data; void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg); void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg); @@ -164,6 +166,8 @@ void arch_restore_msi_irqs(struct pci_dev *dev); void default_teardown_msi_irqs(struct pci_dev *dev); void default_restore_msi_irqs(struct pci_dev *dev); +int pci_bus_msi_isolated(struct pci_bus *bus, struct irq_domain *domain); + struct msi_controller { struct module *owner; struct device *dev; @@ -182,7 +186,6 @@ struct msi_controller { #include <linux/irqhandler.h> #include <asm/msi.h> -struct irq_domain; struct irq_domain_ops; struct irq_chip; struct device_node;
On ARM HW the capability of IRQ remapping is abstracted on MSI controller side. MSI_FLAG_IRQ_REMAPPING is used to advertise this [1]. To have a universal flag to test this capability for different archs on PCI side, we set PCI_BUS_FLAGS_MSI_REMAP for PCI buses when MSI_FLAG_IRQ_REMAPPING is set. [1] https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1138820.html Signed-off-by: Yongji Xie <xyjxie@linux.vnet.ibm.com> --- drivers/pci/msi.c | 15 +++++++++++++++ drivers/pci/probe.c | 3 +++ include/linux/msi.h | 5 ++++- 3 files changed, 22 insertions(+), 1 deletion(-)