| Message ID | 1455757572-44955-3-git-send-email-qiang.zhao@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote: > Add uqe_serial document to > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> > --- > Changes for v2 > - modify tx/rx-clock-name specification > > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > new file mode 100644 > index 0000000..436c71c > --- /dev/null > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > @@ -0,0 +1,19 @@ > +* Serial > + > +Currently defined compatibles: > +- ucc_uart > + > +Properties for ucc_uart: > +port-number : port number of UCC-UART How is this used? > +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source, > + should be "clk1"-"clk28" for external clock source. Perhaps you should be using the clock binding here and in other bindings? > + > +Example: > + > + ucc_serial: ucc@2200 { > + device_type = "serial"; > + compatible = "ucc_uart"; > + port-number = <1>; > + rx-clock-name = "brg2"; > + tx-clock-name = "brg2"; > + }; > -- > 2.1.0.27.g96db324 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2016-02-23 at 14:23 -0600, Rob Herring wrote: > On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote: > > Add uqe_serial document to > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> > > --- > > Changes for v2 > > - modify tx/rx-clock-name specification > > > > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 > > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > > > diff --git > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > new file mode 100644 > > index 0000000..436c71c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > @@ -0,0 +1,19 @@ > > +* Serial > > + > > +Currently defined compatibles: > > +- ucc_uart > > + > > +Properties for ucc_uart: > > +port-number : port number of UCC-UART > > How is this used? > > > +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source, > > + should be "clk1"-"clk28" for external clock source. > > Perhaps you should be using the clock binding here and in other > bindings? These properties are required by the underlying UCC binding (Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt) and predate the clock binding. -Scott
On Wed, Feb 24, 2016 at 04:24AM, Rob Herring wrote: > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: Wednesday, February 24, 2016 4:24 AM > To: Qiang Zhao <qiang.zhao@nxp.com> > Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org > Subject: Re: [PATCH v2 3/7] QE: Add uqe_serial document to bindings > > On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote: > > Add uqe_serial document to > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> > > --- > > Changes for v2 > > - modify tx/rx-clock-name specification > > > > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > > > diff --git > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > new file mode 100644 > > index 0000000..436c71c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial. > > +++ txt > > @@ -0,0 +1,19 @@ > > +* Serial > > + > > +Currently defined compatibles: > > +- ucc_uart > > + > > +Properties for ucc_uart: > > +port-number : port number of UCC-UART > > How is this used? It used for uart port index. BR -Zhao
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt new file mode 100644 index 0000000..436c71c --- /dev/null +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt @@ -0,0 +1,19 @@ +* Serial + +Currently defined compatibles: +- ucc_uart + +Properties for ucc_uart: +port-number : port number of UCC-UART +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source, + should be "clk1"-"clk28" for external clock source. + +Example: + + ucc_serial: ucc@2200 { + device_type = "serial"; + compatible = "ucc_uart"; + port-number = <1>; + rx-clock-name = "brg2"; + tx-clock-name = "brg2"; + };
Add uqe_serial document to Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> --- Changes for v2 - modify tx/rx-clock-name specification .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt