diff mbox

[1/2] powerpc/t1024rdb: add ina220 current sense node

Message ID 1435917049-24227-1-git-send-email-Shengzhou.Liu@freescale.com (mailing list archive)
State Superseded
Headers show

Commit Message

Shengzhou Liu July 3, 2015, 9:50 a.m. UTC
Add support for INA220 current sense.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
---
 arch/powerpc/boot/dts/t1024rdb.dts | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Scott Wood July 6, 2015, 9:48 p.m. UTC | #1
On Fri, 2015-07-03 at 17:50 +0800, Shengzhou Liu wrote:
> Add support for INA220 current sense.
> 
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> ---
>  arch/powerpc/boot/dts/t1024rdb.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/t1024rdb.dts 
> b/arch/powerpc/boot/dts/t1024rdb.dts
> index 733e723..43474d9 100644
> --- a/arch/powerpc/boot/dts/t1024rdb.dts
> +++ b/arch/powerpc/boot/dts/t1024rdb.dts
> @@ -114,6 +114,13 @@
>                               reg = <0x4c>;
>                       };
>  
> +                     /* INA220 Current Sense */

Do you mean "current sensor"?

Why is this comment needed here, but not in the t1023 file?

> +                      ina220@40{

Node names should be generic (which would also eliminate any reason for the 
above comment).

-Scott
diff mbox

Patch

diff --git a/arch/powerpc/boot/dts/t1024rdb.dts b/arch/powerpc/boot/dts/t1024rdb.dts
index 733e723..43474d9 100644
--- a/arch/powerpc/boot/dts/t1024rdb.dts
+++ b/arch/powerpc/boot/dts/t1024rdb.dts
@@ -114,6 +114,13 @@ 
 				reg = <0x4c>;
 			};
 
+			/* INA220 Current Sense */
+			ina220@40 {
+				compatible = "ti,ina220";
+				reg = <0x40>;
+				shunt-resistor = <1000>;
+			};
+
 			eeprom@50 {
 				compatible = "atmel,24c256";
 				reg = <0x50>;