From patchwork Mon Jun 29 10:35:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maninder Singh X-Patchwork-Id: 489460 X-Patchwork-Delegate: michael@ellerman.id.au Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B74A1140914 for ; Tue, 30 Jun 2015 11:36:29 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 9D3371A117C for ; Tue, 30 Jun 2015 11:36:29 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org X-Greylist: delayed 602 seconds by postgrey-1.35 at bilbo; Mon, 29 Jun 2015 20:45:58 AEST Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id C06E41A0D30 for ; Mon, 29 Jun 2015 20:45:58 +1000 (AEST) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NQP01K4HC3RRYB0@mailout2.samsung.com> for linuxppc-dev@lists.ozlabs.org; Mon, 29 Jun 2015 19:35:51 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.122]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 8B.C9.24422.78F11955; Mon, 29 Jun 2015 19:35:51 +0900 (KST) X-AuditID: cbfee68f-f793b6d000005f66-0c-55911f876372 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id AC.29.05312.78F11955; Mon, 29 Jun 2015 19:35:51 +0900 (KST) Received: from localhost.localdomain ([107.108.92.210]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NQP001Y0C2RYL50@mmp1.samsung.com>; Mon, 29 Jun 2015 19:35:51 +0900 (KST) From: Maninder Singh To: imunsie@au1.ibm.com, mikey@neuling.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] cxl/vphb.c: Use phb pointer after NULL check Date: Mon, 29 Jun 2015 16:05:11 +0530 Message-id: <1435574111-45617-1-git-send-email-maninder1.s@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDLMWRmVeSWpSXmKPExsWyRsSkSrddfmKowaHnBhbLG54yW1zeNYfN 4vf3f6wWh+e3sVgs7ZvGbHHvzVYmBzaPN8+XMHqcn7GQ0eP7wmZGj74tqxg9Pm+SC2CN4rJJ Sc3JLEst0rdL4Mo4v/cre0ETe0Xr2zesDYyvWLsYOTkkBEwkug+tYISwxSQu3FvP1sXIxSEk sJRR4uiyFywwRYdv7YdKLGKU6H56Esr5ySixefkDsHY2AT2JVbv2AHVwcIgIZEqsWS8PYjIL OElM/6oHUiEs4Chx48ZZJhCbRUBVYvK8LrD5vALuEn0r7rGClEsIKEjMmWQDMl1C4DubxJmD bxkh6gUkvk0+xAJRIyux6QAzxGmSEgdX3GCZwCi4gJFhFaNoakFyQXFSepGxXnFibnFpXrpe cn7uJkZgoJ7+96x/B+PdA9aHGAU4GJV4eBd8nBAqxJpYVlyZe4jRFGjDRGYp0eR8YDzklcQb GpsZWZiamBobmVuaKYnzLpT6GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qB0e1Wg6pV7n+O NM0zF523GixbkrZ5aUnSG2/9987dD51rEvVOrat4Fyvf48sk/9OH18ZMi+ljz5PdX06+OTYn 00Xebo6eGven8rlFqS8kspfzFL5Q1JQsW2uQvqKge5Oxj8615zcXvsuQSI5hO73/7eHlTyZt bmE/9HUxy2KZszuT8ifUJW/RVWIpzkg01GIuKk4EAIfOuQdPAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42I5/e+xgG67/MRQg2v71SyWNzxltri8aw6b xe/v/1gtDs9vY7FY2jeN2eLem61MDmweb54vYfQ4P2Mho8f3hc2MHn1bVjF6fN4kF8Aa1cBo k5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQN0gpJCWWJO KVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYx4/zer+wFTewVrW/fsDYwvmLtYuTk kBAwkTh8az8bhC0mceHeeiCbi0NIYBGjRPfTk1DOT0aJzcsfMIJUsQnoSazatYeli5GDQ0Qg U2LNenkQk1nASWL6Vz2QCmEBR4kbN84ygdgsAqoSk+d1sYDYvALuEn0r7rGClEsIKEjMmWQz gZF7ASPDKkbR1ILkguKk9FwjveLE3OLSvHS95PzcTYzgOHgmvYNxVYPFIUYBDkYlHl6HFxNC hVgTy4orcw8xSnAwK4nwXt4MFOJNSaysSi3Kjy8qzUktPsRoCrR8IrOUaHI+MEbzSuINjU3M TY1NLU0sTMwslcR5T+b7hAoJpCeWpGanphakFsH0MXFwSjUwNjBsuaGjdH6uwduAK+uadpsv vZystepHHue2SQc4fxfdU+223yqnx3Bz6//VG60t/Y7ULToh+Kbz2D72X8z9u1JZrnz12HrS WaD0me9pZSHt3ZtZrG9PSXR93XiM2d9vp0bexf8K30SVtJ2Xsu4psJl+Ip5TaMUT7+h7FQq+ iY5reh8wdfgwKrEUZyQaajEXFScCAJZlUImZAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Mailman-Approved-At: Tue, 30 Jun 2015 11:35:37 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maninder Singh , pankaj.m@samsung.com MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" static Anlaysis detected below error:- (error) Possible null pointer dereference: phb So, Use phb after NULL check. Signed-off-by: Maninder Singh Acked-by: Ian Munsie --- drivers/misc/cxl/vphb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c index b1d1983a..2eba002 100644 --- a/drivers/misc/cxl/vphb.c +++ b/drivers/misc/cxl/vphb.c @@ -112,9 +112,10 @@ static int cxl_pcie_config_info(struct pci_bus *bus, unsigned int devfn, unsigned long addr; phb = pci_bus_to_host(bus); - afu = (struct cxl_afu *)phb->private_data; if (phb == NULL) return PCIBIOS_DEVICE_NOT_FOUND; + afu = (struct cxl_afu *)phb->private_data; + if (cxl_pcie_cfg_record(bus->number, devfn) > afu->crs_num) return PCIBIOS_DEVICE_NOT_FOUND; if (offset >= (unsigned long)phb->cfg_data)