From patchwork Fri Feb 20 16:21:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Hicks X-Patchwork-Id: 442028 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BC3B614018C for ; Sat, 21 Feb 2015 03:24:07 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 24D4C1A0FCC for ; Sat, 21 Feb 2015 03:24:07 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-ie0-x22d.google.com (mail-ie0-x22d.google.com [IPv6:2607:f8b0:4001:c03::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id BACEA1A0F0B for ; Sat, 21 Feb 2015 03:21:49 +1100 (AEDT) Received: by iebtr6 with SMTP id tr6so8924625ieb.7 for ; Fri, 20 Feb 2015 08:21:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=5R3C7fjDro8K6o8OWL/sukfqGa09myktTjeRw+PKWQU=; b=aw1L0vj9PHMjXu8Gco+xz029xsmaYRcfbkbyrd/Y58tEwq9CtQk6wo8E8kbeeXNIpK Mx+pzO3wyFc2VwFP0qm9mih4ORjTKGKnIihiAyD82Su6uuGApNdusOgu1wilMdffMBMX FW3F3s23SMANScLCBBeAqxsUVCd2IRoS8ND26rixpXMA6X72jVgtN0PyNTYk/LjRg+XW 18Cj4Gmb/gFRvYJt9O5P5x/lEYN2TecXNd5oFnzNE3XxrTb9uDHSI/6TCSRqTxQ01UvR DtkF0RdT7KytmKWQXQuhw0/tqt4tAiwxsc+a8uzQG6d/4ksm0QSgIuGWtCbABo072ZWT uZtQ== X-Received: by 10.50.142.99 with SMTP id rv3mr18199955igb.11.1424449307748; Fri, 20 Feb 2015 08:21:47 -0800 (PST) Received: from p1022build.eng-services.ca (cmr-208-97-87-171.cr.net.cable.rogers.com. [208.97.87.171]) by mx.google.com with ESMTPSA id n17sm3025997igi.2.2015.02.20.08.21.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 08:21:47 -0800 (PST) From: Martin Hicks To: Kim Phillips , Scott Wood , Kumar Gala Subject: [PATCH 1/5] crypto: talitos: Simplify per-channel initialization Date: Fri, 20 Feb 2015 11:21:12 -0500 Message-Id: <1424449276-5288-2-git-send-email-mort@bork.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1424449276-5288-1-git-send-email-mort@bork.org> References: <1424449276-5288-1-git-send-email-mort@bork.org> Cc: Martin Hicks , linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" There were multiple loops in a row, for each separate step of the initialization of the channels. Simplify to a single loop. Signed-off-by: Martin Hicks --- drivers/crypto/talitos.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index 067ec21..c49d977 100644 --- a/drivers/crypto/talitos.c +++ b/drivers/crypto/talitos.c @@ -2706,20 +2706,16 @@ static int talitos_probe(struct platform_device *ofdev) goto err_out; } + priv->fifo_len = roundup_pow_of_two(priv->chfifo_len); + for (i = 0; i < priv->num_channels; i++) { priv->chan[i].reg = priv->reg + TALITOS_CH_STRIDE * (i + 1); if (!priv->irq[1] || !(i & 1)) priv->chan[i].reg += TALITOS_CH_BASE_OFFSET; - } - for (i = 0; i < priv->num_channels; i++) { spin_lock_init(&priv->chan[i].head_lock); spin_lock_init(&priv->chan[i].tail_lock); - } - priv->fifo_len = roundup_pow_of_two(priv->chfifo_len); - - for (i = 0; i < priv->num_channels; i++) { priv->chan[i].fifo = kzalloc(sizeof(struct talitos_request) * priv->fifo_len, GFP_KERNEL); if (!priv->chan[i].fifo) { @@ -2727,11 +2723,10 @@ static int talitos_probe(struct platform_device *ofdev) err = -ENOMEM; goto err_out; } - } - for (i = 0; i < priv->num_channels; i++) atomic_set(&priv->chan[i].submit_count, -(priv->chfifo_len - 1)); + } dma_set_mask(dev, DMA_BIT_MASK(36));