| Message ID | 1403597935-39952-1-git-send-email-B45475@freescale.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, 2014-06-24 at 16:18 +0800, Zhao Qiang wrote: > deal with a compile warning: comparison between > 'enum qe_fltr_largest_external_tbl_lookup_key_size' > and 'enum qe_fltr_tbl_lookup_key_size' > > the code: > "if (ug_info->largestexternallookupkeysize == > QE_FLTR_TABLE_LOOKUP_KEY_SIZE_8_BYTES)" > is warned because different enum, so modify it. > > "enum qe_fltr_largest_external_tbl_lookup_key_size > largestexternallookupkeysize; > > enum qe_fltr_tbl_lookup_key_size { > QE_FLTR_TABLE_LOOKUP_KEY_SIZE_8_BYTES > = 0x3f, /* LookupKey parsed by the Generate LookupKey > CMD is truncated to 8 bytes */ > QE_FLTR_TABLE_LOOKUP_KEY_SIZE_16_BYTES > = 0x5f, /* LookupKey parsed by the Generate LookupKey > CMD is truncated to 16 bytes */ > }; > > /* QE FLTR extended filtering Largest External Table Lookup Key Size */ > enum qe_fltr_largest_external_tbl_lookup_key_size { > QE_FLTR_LARGEST_EXTERNAL_TABLE_LOOKUP_KEY_SIZE_NONE > = 0x0,/* not used */ > QE_FLTR_LARGEST_EXTERNAL_TABLE_LOOKUP_KEY_SIZE_8_BYTES > = QE_FLTR_TABLE_LOOKUP_KEY_SIZE_8_BYTES, /* 8 bytes */ > QE_FLTR_LARGEST_EXTERNAL_TABLE_LOOKUP_KEY_SIZE_16_BYTES > = QE_FLTR_TABLE_LOOKUP_KEY_SIZE_16_BYTES, /* 16 bytes */ > };" > > Signed-off-by: Zhao Qiang <B45475@freescale.com> > --- > drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This needs to be sent to the netdev list and maintainer. -Scott
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index ee2f1ff..0b0de89 100644 --- a/drivers/net/ethernet/freescale/ucc_geth.c +++ b/drivers/net/ethernet/freescale/ucc_geth.c @@ -2993,11 +2993,11 @@ static int ucc_geth_startup(struct ucc_geth_private *ugeth) if (ug_info->rxExtendedFiltering) { size += THREAD_RX_PRAM_ADDITIONAL_FOR_EXTENDED_FILTERING; if (ug_info->largestexternallookupkeysize == - QE_FLTR_TABLE_LOOKUP_KEY_SIZE_8_BYTES) + QE_FLTR_LARGEST_EXTERNAL_TABLE_LOOKUP_KEY_SIZE_8_BYTES) size += THREAD_RX_PRAM_ADDITIONAL_FOR_EXTENDED_FILTERING_8; if (ug_info->largestexternallookupkeysize == - QE_FLTR_TABLE_LOOKUP_KEY_SIZE_16_BYTES) + QE_FLTR_LARGEST_EXTERNAL_TABLE_LOOKUP_KEY_SIZE_16_BYTES) size += THREAD_RX_PRAM_ADDITIONAL_FOR_EXTENDED_FILTERING_16; }
deal with a compile warning: comparison between 'enum qe_fltr_largest_external_tbl_lookup_key_size' and 'enum qe_fltr_tbl_lookup_key_size' the code: "if (ug_info->largestexternallookupkeysize == QE_FLTR_TABLE_LOOKUP_KEY_SIZE_8_BYTES)" is warned because different enum, so modify it. "enum qe_fltr_largest_external_tbl_lookup_key_size largestexternallookupkeysize; enum qe_fltr_tbl_lookup_key_size { QE_FLTR_TABLE_LOOKUP_KEY_SIZE_8_BYTES = 0x3f, /* LookupKey parsed by the Generate LookupKey CMD is truncated to 8 bytes */ QE_FLTR_TABLE_LOOKUP_KEY_SIZE_16_BYTES = 0x5f, /* LookupKey parsed by the Generate LookupKey CMD is truncated to 16 bytes */ }; /* QE FLTR extended filtering Largest External Table Lookup Key Size */ enum qe_fltr_largest_external_tbl_lookup_key_size { QE_FLTR_LARGEST_EXTERNAL_TABLE_LOOKUP_KEY_SIZE_NONE = 0x0,/* not used */ QE_FLTR_LARGEST_EXTERNAL_TABLE_LOOKUP_KEY_SIZE_8_BYTES = QE_FLTR_TABLE_LOOKUP_KEY_SIZE_8_BYTES, /* 8 bytes */ QE_FLTR_LARGEST_EXTERNAL_TABLE_LOOKUP_KEY_SIZE_16_BYTES = QE_FLTR_TABLE_LOOKUP_KEY_SIZE_16_BYTES, /* 16 bytes */ };" Signed-off-by: Zhao Qiang <B45475@freescale.com> --- drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)