| Message ID | 1401981868-4108-1-git-send-email-shreyas@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 06/05/2014 08:54 PM, Shreyas B. Prabhu wrote: > Build throws following errors when CONFIG_SMP=n > arch/powerpc/platforms/powernv/subcore.c: In function ‘cpu_update_split_mode’: > arch/powerpc/platforms/powernv/subcore.c:274:15: error: ‘setup_max_cpus’ undeclared (first use in this function) > arch/powerpc/platforms/powernv/subcore.c:285:5: error: lvalue required as left operand of assignment > > 'setup_max_cpus' variable is relevant only on SMP, so there is no point > working around it for UP. Furthermore, subcore.c itself is relevant only > on SMP and hence the better solution is to exclude subcore.c for UP builds. > > Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com> > --- > This patch applies on top of ben/powerpc.git/next branch > > arch/powerpc/platforms/powernv/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/Makefile b/arch/powerpc/platforms/powernv/Makefile > index 4ad0d34..636d206 100644 > --- a/arch/powerpc/platforms/powernv/Makefile > +++ b/arch/powerpc/platforms/powernv/Makefile > @@ -1,9 +1,9 @@ > obj-y += setup.o opal-takeover.o opal-wrappers.o opal.o opal-async.o > obj-y += opal-rtc.o opal-nvram.o opal-lpc.o opal-flash.o > obj-y += rng.o opal-elog.o opal-dump.o opal-sysparam.o opal-sensor.o > -obj-y += opal-msglog.o subcore.o subcore-asm.o > +obj-y += opal-msglog.o subcore-asm.o > subcore-asm.o can also move down here as well ? > -obj-$(CONFIG_SMP) += smp.o > +obj-$(CONFIG_SMP) += smp.o subcore.o
diff --git a/arch/powerpc/platforms/powernv/Makefile b/arch/powerpc/platforms/powernv/Makefile index 4ad0d34..636d206 100644 --- a/arch/powerpc/platforms/powernv/Makefile +++ b/arch/powerpc/platforms/powernv/Makefile @@ -1,9 +1,9 @@ obj-y += setup.o opal-takeover.o opal-wrappers.o opal.o opal-async.o obj-y += opal-rtc.o opal-nvram.o opal-lpc.o opal-flash.o obj-y += rng.o opal-elog.o opal-dump.o opal-sysparam.o opal-sensor.o -obj-y += opal-msglog.o subcore.o subcore-asm.o +obj-y += opal-msglog.o subcore-asm.o -obj-$(CONFIG_SMP) += smp.o +obj-$(CONFIG_SMP) += smp.o subcore.o obj-$(CONFIG_PCI) += pci.o pci-p5ioc2.o pci-ioda.o obj-$(CONFIG_EEH) += eeh-ioda.o eeh-powernv.o obj-$(CONFIG_PPC_SCOM) += opal-xscom.o
Build throws following errors when CONFIG_SMP=n arch/powerpc/platforms/powernv/subcore.c: In function ‘cpu_update_split_mode’: arch/powerpc/platforms/powernv/subcore.c:274:15: error: ‘setup_max_cpus’ undeclared (first use in this function) arch/powerpc/platforms/powernv/subcore.c:285:5: error: lvalue required as left operand of assignment 'setup_max_cpus' variable is relevant only on SMP, so there is no point working around it for UP. Furthermore, subcore.c itself is relevant only on SMP and hence the better solution is to exclude subcore.c for UP builds. Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com> --- This patch applies on top of ben/powerpc.git/next branch arch/powerpc/platforms/powernv/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)