diff mbox

[09/12] mpc5121ads: Added I2C RTC node to mpc5121ads DTS.

Message ID 1241640919-4650-10-git-send-email-wd@denx.de (mailing list archive)
State Changes Requested, archived
Delegated to: Grant Likely
Headers show

Commit Message

Wolfgang Denk May 6, 2009, 8:15 p.m. UTC 
From: Piotr Ziecik <kosmo@semihalf.com>

Signed-off-by: Piotr Ziecik <kosmo@semihalf.com>
Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: John Rigby <jcrigby@gmail.com>
---
 arch/powerpc/boot/dts/mpc5121ads.dts |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Comments

Grant Likely May 6, 2009, 9:02 p.m. UTC | #1 
On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote:
> From: Piotr Ziecik <kosmo@semihalf.com>
>
> Signed-off-by: Piotr Ziecik <kosmo@semihalf.com>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Grant Likely <grant.likely@secretlab.ca>

Acked-by: Grant Likely <grant.likely@secretlab.ca>

> Cc: John Rigby <jcrigby@gmail.com>
> ---
>  arch/powerpc/boot/dts/mpc5121ads.dts |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts
> index 93fe12a..c2d9de9 100644
> --- a/arch/powerpc/boot/dts/mpc5121ads.dts
> +++ b/arch/powerpc/boot/dts/mpc5121ads.dts
> @@ -210,6 +210,11 @@
>                        interrupts = <9 0x8>;
>                        interrupt-parent = < &ipic >;
>                        fsl5200-clocking;
> +
> +                       rtc@68 {
> +                               compatible = "stm,m41t80";
> +                               reg = <0x68>;
> +                       };
>                };
>
>                i2c@1720 {
> --
> 1.6.0.6
>
>
Wolfgang Grandegger May 7, 2009, 6:45 a.m. UTC | #2 
Wolfgang Denk wrote:
> From: Piotr Ziecik <kosmo@semihalf.com>
> 
> Signed-off-by: Piotr Ziecik <kosmo@semihalf.com>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: John Rigby <jcrigby@gmail.com>
> ---
>  arch/powerpc/boot/dts/mpc5121ads.dts |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts
> index 93fe12a..c2d9de9 100644
> --- a/arch/powerpc/boot/dts/mpc5121ads.dts
> +++ b/arch/powerpc/boot/dts/mpc5121ads.dts
> @@ -210,6 +210,11 @@
>  			interrupts = <9 0x8>;
>  			interrupt-parent = < &ipic >;
>  			fsl5200-clocking;

The above line is obsolete since -rc4. Please check the revised bindings
in Documentation/powerpc/dts-bindings/fsl/i2c.txt. You may even want:

                        clock-frequency = <100000>;

Wolfgang.
diff mbox

Patch

diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts
index 93fe12a..c2d9de9 100644
--- a/arch/powerpc/boot/dts/mpc5121ads.dts
+++ b/arch/powerpc/boot/dts/mpc5121ads.dts
@@ -210,6 +210,11 @@ 
 			interrupts = <9 0x8>;
 			interrupt-parent = < &ipic >;
 			fsl5200-clocking;
+
+			rtc@68 {
+				compatible = "stm,m41t80";
+				reg = <0x68>;
+			};
 		};
 
 		i2c@1720 {