| Message ID | f33ebe524590314238b48fe620c9af717b1db096.1676416728.git.development@efficientek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | GDB: Support getting current task struct in UML | expand |
On 15.02.23 00:35, Glenn Washburn wrote: > There is an extra space in a couple blocks in get_current_task. > Though python does not care, let's make the spacing consistent. > > Signed-off-by: Glenn Washburn <development@efficientek.com> > --- > scripts/gdb/linux/cpus.py | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/scripts/gdb/linux/cpus.py b/scripts/gdb/linux/cpus.py > index 15fc4626d236..289f0bf4d2a1 100644 > --- a/scripts/gdb/linux/cpus.py > +++ b/scripts/gdb/linux/cpus.py > @@ -163,16 +163,16 @@ def get_current_task(cpu): > task_ptr_type = task_type.get_type().pointer() > > if utils.is_target_arch("x86"): > - var_ptr = gdb.parse_and_eval("¤t_task") > - return per_cpu(var_ptr, cpu).dereference() > + var_ptr = gdb.parse_and_eval("¤t_task") > + return per_cpu(var_ptr, cpu).dereference() > elif utils.is_target_arch("aarch64"): > - current_task_addr = gdb.parse_and_eval("$SP_EL0") > - if((current_task_addr >> 63) != 0): > - current_task = current_task_addr.cast(task_ptr_type) > - return current_task.dereference() > - else: > - raise gdb.GdbError("Sorry, obtaining the current task is not allowed " > - "while running in userspace(EL0)") > + current_task_addr = gdb.parse_and_eval("$SP_EL0") > + if((current_task_addr >> 63) != 0): At this chance: "if (current_task_addr >> 63) != 0:" > + current_task = current_task_addr.cast(task_ptr_type) > + return current_task.dereference() > + else: > + raise gdb.GdbError("Sorry, obtaining the current task is not allowed " > + "while running in userspace(EL0)") > else: > raise gdb.GdbError("Sorry, obtaining the current task is not yet " > "supported with this arch") Jan
diff --git a/scripts/gdb/linux/cpus.py b/scripts/gdb/linux/cpus.py index 15fc4626d236..289f0bf4d2a1 100644 --- a/scripts/gdb/linux/cpus.py +++ b/scripts/gdb/linux/cpus.py @@ -163,16 +163,16 @@ def get_current_task(cpu): task_ptr_type = task_type.get_type().pointer() if utils.is_target_arch("x86"): - var_ptr = gdb.parse_and_eval("¤t_task") - return per_cpu(var_ptr, cpu).dereference() + var_ptr = gdb.parse_and_eval("¤t_task") + return per_cpu(var_ptr, cpu).dereference() elif utils.is_target_arch("aarch64"): - current_task_addr = gdb.parse_and_eval("$SP_EL0") - if((current_task_addr >> 63) != 0): - current_task = current_task_addr.cast(task_ptr_type) - return current_task.dereference() - else: - raise gdb.GdbError("Sorry, obtaining the current task is not allowed " - "while running in userspace(EL0)") + current_task_addr = gdb.parse_and_eval("$SP_EL0") + if((current_task_addr >> 63) != 0): + current_task = current_task_addr.cast(task_ptr_type) + return current_task.dereference() + else: + raise gdb.GdbError("Sorry, obtaining the current task is not allowed " + "while running in userspace(EL0)") else: raise gdb.GdbError("Sorry, obtaining the current task is not yet " "supported with this arch")
There is an extra space in a couple blocks in get_current_task. Though python does not care, let's make the spacing consistent. Signed-off-by: Glenn Washburn <development@efficientek.com> --- scripts/gdb/linux/cpus.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)