| Message ID | 20250924142059.527768-5-benjamin@sipsolutions.net |
|---|---|
| State | Changes Requested |
| Headers | show
Return-Path: <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4cWzZ06NXJz1yGJ for <incoming@patchwork.ozlabs.org>; Thu, 25 Sep 2025 00:21:59 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z10b0FVwCq0i5SVTTgonk/hnK8AmJrJFJmxu+fzz9NI=; b=b610T1C2WlfEizOny4EVdAAL1H OTnJoPbPeGGtcCnmce+vNO/ZFFLVbUKjYYCL4686K9tD9hT32BZN0lTDyybvAyFkw/q8fz+K5uYHT ZVkdCDi/j5gu4RJw/OANSkAcskD8BUeW6+7liw9NlGAotpjWkbgzwSFBJ0aI6V9WO1+UgnTVW8lh3 ls9MsPU1askOYmSQ4+v0l/N9IJK+vh2He2tey724EHANAPsaaKLfYiIiNHZaFJcu/6Tuo5Heq3n2j t7y9NHzO4s9/7Ehf1shMLRQrBwOdjFhDVznAjM8NR4Gm5IBJ8yWm+Kd/oBQl1me8JxEgRlzuKlAle ayCQmbNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v1QNa-00000000aqQ-1Gtg; Wed, 24 Sep 2025 14:21:58 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v1QNX-00000000ajH-0ZSq for linux-um@lists.infradead.org; Wed, 24 Sep 2025 14:21:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=z10b0FVwCq0i5SVTTgonk/hnK8AmJrJFJmxu+fzz9NI=; t=1758723715; x=1759933315; b=gacHYJcsksoJrgZw8Qe+4D54xOOV60mBuGy13K9PryVdkCo OQWmqOKUvrkd4Jl7lT/27raD4YkSwEnE4QvwcNItpQ5pcXYU1WEMaNh+owkAp7s3Obx5HRobcNUzh R/vrT6o0dp34UKPnLXT8g6LqYzHsTZ+K0vhvaLQYUqL69Qj9sKgf8qFOVhiy8v3lGwrxoi/kywHqX 0TQyxKxjdUmZij0QfG6oWIS6+c/YuxuHvRlq6zJubfujXTGR6KVXEUC5hYYl9TUUExjhca4Ktbr4A KmkPCHBPwcXxGf4CjmxJZ+HMPug+VB5VSt7Z60pGEjOq/B6BYI8GfUIb/J86Loow==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from <benjamin@sipsolutions.net>) id 1v1QNU-000000090Bz-0suP; Wed, 24 Sep 2025 16:21:52 +0200 From: Benjamin Berg <benjamin@sipsolutions.net> To: linux-um@lists.infradead.org, Willy Tarreau <w@1wt.eu>, =?utf-8?q?Thomas?= =?utf-8?q?_Wei=C3=9Fschuh?= <linux@weissschuh.net>, linux-kselftest@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com> Cc: linux-kernel@vger.kernel.org, Benjamin Berg <benjamin.berg@intel.com> Subject: [PATCH v3 04/12] tools/nolibc/dirent: avoid errno in readdir_r Date: Wed, 24 Sep 2025 16:20:51 +0200 Message-ID: <20250924142059.527768-5-benjamin@sipsolutions.net> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924142059.527768-1-benjamin@sipsolutions.net> References: <20250924142059.527768-1-benjamin@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250924_072155_183673_44C37329 X-CRM114-Status: GOOD ( 11.78 ) X-Spam-Score: -2.1 (--) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__From=3A_Benjamin_Berg_=3Cbenjamin=2Ebe?= =?unknown-8bit?q?rg=40intel=2Ecom=3E_Using_errno?= =?unknown-8bit?q?_is_not_possible_when_NOLIBC=5FIGNORE=5FERRNO_is_set=2E_Use?= =?unknown-8bit?q?_sys=5Flseek_instead_of?= =?unknown-8bit?q?_lseek_as_that_avoids_using_errno=2E_Fixes=3A_665fa8dea90d_?= =?unknown-8bit?q?=28=22tools/nolibc=3A_add?= =?unknown-8bit?q?_support_for_directory_access=22=29_Signed-off-by=3A_Benjam?= =?unknown-8bit?q?in_Berg_=3Cbenjamin=2Eberg=40intel=2Ecom=3E?= =?unknown-8bit?q?_Acked-by=3A_Thomas_Wei=C3=9Fschuh_=3Clinux=40weissschuh=2E?= =?unknown-8bit?q?net=3E_---_tools/include/nolib?= =?unknown-8bit?b?IFsuLi5dIA==?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=28-2=2E1_points=2C_5=2E0_re?= =?unknown-8bit?q?quired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_SPF=5FHELO=5FPASS__________SPF=3A_HELO_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from?= =?unknown-8bit?q?_envelope-from_domain?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from_author=27s?= =?unknown-8bit?q?_domain?= =?unknown-8bit?q?_-1=2E9_BAYES=5F00_______________BODY=3A_Bayes_spam_probabi?= =?unknown-8bit?q?lity_is_0_to_1=25?= =?unknown-8bit?q?_=5Bscore=3A_0=2E0000=5D?= X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-um.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-um/> List-Post: <mailto:linux-um@lists.infradead.org> List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=subscribe> Sender: "linux-um" <linux-um-bounces@lists.infradead.org> Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
| Series |
Start porting UML to nolibc
|
expand
|
diff --git a/tools/include/nolibc/dirent.h b/tools/include/nolibc/dirent.h index 758b95c48e7a..61a122a60327 100644 --- a/tools/include/nolibc/dirent.h +++ b/tools/include/nolibc/dirent.h @@ -86,9 +86,9 @@ int readdir_r(DIR *dirp, struct dirent *entry, struct dirent **result) * readdir() can only return one entry at a time. * Make sure the non-returned ones are not skipped. */ - ret = lseek(fd, ldir->d_off, SEEK_SET); - if (ret == -1) - return errno; + ret = sys_lseek(fd, ldir->d_off, SEEK_SET); + if (ret < 0) + return -ret; entry->d_ino = ldir->d_ino; /* the destination should always be big enough */