From patchwork Fri Feb 2 19:56:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yueh-Shun Li X-Patchwork-Id: 1894768 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EhKdDHDB; dkim=pass (2048-bit key; secure) header.d=posteo.net header.i=@posteo.net header.a=rsa-sha256 header.s=2017 header.b=hDqww7k1; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TRSt807Dvz1yQ0 for ; Sat, 3 Feb 2024 08:03:25 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=8L33DBBndo3NokgAYjpkdsaWW74PWfcxGD0pnplvp7U=; b=EhKdDHDB7S5O7HemZ4DSCVRX+w 1RqceCp8nJFpefFwkIe6SfMOQz3NkEbXu+yiYWp62KqK2KEOSCNW1P7+/6F8glxHH3qpJIihMG5FD vq9fjQbqhbrKO3I3bWlaNSWGOABSRmaKgfn5u16JfO0fAAab6pK/7pbrhIgPVXp1N0y7/SnbvmCJl Cy5rdFJ1dh8cRbYi0vHZwLsgcjdR7vunOCEGd2/yh7/ZAF0rj4xCTY3BgSlJf0lZrWxGEiy9fRs4U HrEZ464ONAk7hbxdKF03M0Z/ep00MQhFkD0TTMReuXKOpod2e8AGr1DtkDjbw+1j9Nxac6WbdwRcP iIT8AYWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rW0h0-0000000DStl-3X8I; Fri, 02 Feb 2024 21:03:22 +0000 Received: from mout02.posteo.de ([185.67.36.66]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVzfn-0000000DHlC-0v9c for linux-um@lists.infradead.org; Fri, 02 Feb 2024 19:58:18 +0000 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4A8E4240101 for ; Fri, 2 Feb 2024 20:57:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706903879; bh=ZjzdVNfrMUY9UbVAc1VBiqKQvpy3NY8jNomBSoF8YQg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=hDqww7k1xSH3YS9NyU1U28mv8gyk1ry5awu7xlodsYIIk4O2fLsbBE9+M1IFr/WQM EUCeqAHXHalRpQx4KBL+zKeqTy2FsguPk6FfbeycHb8qTOfZ1PolxAbmmodMGoF189 3CGyLU/yOj5WNm/1fw9MAg3AOZUfuo3wnXWRIotznjP91oZFPA7TdKrvbi2WzVt9X9 vsWYrR7ys9VbaeQd+aK+P9LvRFC/EOoZ7sDSxdiCTUtOyzbu8batzONrJK4N+6DNPP cSmpXl6FyfNcrapy2G0aQk1q3TkmznRJIJssQsrV9bkLaYtbZyYqpGzN8bBKHYQbDL NqKkz9q4IxgMw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TRRQW0V8Zz9rxG; Fri, 2 Feb 2024 20:57:54 +0100 (CET) From: Yueh-Shun Li To: Richard Weinberger , Anton Ivanov , Johannes Berg Cc: Yueh-Shun Li , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] um: Makefile: use bash from the environment Date: Fri, 2 Feb 2024 19:56:33 +0000 Message-ID: <20240202195645.3224648-1-shamrocklee@posteo.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240202_115803_484516_3100E856 X-CRM114-Status: UNSURE ( 8.81 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Set Makefile SHELL to bash instead of /bin/bash for better portability. Some systems do not install binaries to /bin, and therefore do not provide /bin/bash. OS distributions such as NixOS and Guix System intentionally avoid implementing the Filesystem Hierarchy Standard [...] Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [185.67.36.66 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [185.67.36.66 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Set Makefile SHELL to bash instead of /bin/bash for better portability. Some systems do not install binaries to /bin, and therefore do not provide /bin/bash. OS distributions such as NixOS and Guix System intentionally avoid implementing the Filesystem Hierarchy Standard (FHS). The recipies inside arch/um/Makefile don't require top-level Bash to build, and setting "SHELL" to "bash" makes Make pick the Bash executable from the environment[2], hence this patch. Signed-off-by: Yueh-Shun Li --- arch/um/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/Makefile b/arch/um/Makefile index 82f05f250634..904e2b990963 100644 --- a/arch/um/Makefile +++ b/arch/um/Makefile @@ -20,7 +20,7 @@ endif ARCH_DIR := arch/um # We require bash because the vmlinux link and loader script cpp use bash # features. -SHELL := /bin/bash +SHELL := bash MODE_INCLUDE += -I$(srctree)/$(ARCH_DIR)/include/shared/skas