| Message ID | 20230312235553.26298-1-rdunlap@infradead.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] UML: pata_cs5536: fix build for X86_32 UML with TRACEPOINTS | expand |
On 3/13/23 08:55, Randy Dunlap wrote: > Current build of pata_cs5536 for i386 UML fails with: > > ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > > Add the arch/x86/lib/msr.o binary to resolve these undefined symbols. > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Richard Weinberger <richard@nod.at> > Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> > Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> > Cc: linux-ide@vger.kernel.org > Cc: linux-um@lists.infradead.org > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > --- > arch/x86/um/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/arch/x86/um/Makefile b/arch/x86/um/Makefile > --- a/arch/x86/um/Makefile > +++ b/arch/x86/um/Makefile > @@ -21,7 +21,7 @@ obj-y += checksum_32.o syscalls_32.o > obj-$(CONFIG_ELF_CORE) += elfcore.o > > subarch-y = ../lib/string_32.o ../lib/atomic64_32.o ../lib/atomic64_cx8_32.o > -subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o > +subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o ../lib/msr.o > subarch-y += ../kernel/sys_ia32.o > > else Looks OK to me. Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
diff -- a/arch/x86/um/Makefile b/arch/x86/um/Makefile --- a/arch/x86/um/Makefile +++ b/arch/x86/um/Makefile @@ -21,7 +21,7 @@ obj-y += checksum_32.o syscalls_32.o obj-$(CONFIG_ELF_CORE) += elfcore.o subarch-y = ../lib/string_32.o ../lib/atomic64_32.o ../lib/atomic64_cx8_32.o -subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o +subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o ../lib/msr.o subarch-y += ../kernel/sys_ia32.o else
Current build of pata_cs5536 for i386 UML fails with: ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined! ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined! ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined! ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined! Add the arch/x86/lib/msr.o binary to resolve these undefined symbols. Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Richard Weinberger <richard@nod.at> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> Cc: linux-ide@vger.kernel.org Cc: linux-um@lists.infradead.org Cc: Geert Uytterhoeven <geert@linux-m68k.org> --- arch/x86/um/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)