| Message ID | 20230312052624.8402-1-rdunlap@infradead.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ata: pata_cs5536: don't build on UML | expand |
Hi Randy, On Sun, Mar 12, 2023 at 6:26 AM Randy Dunlap <rdunlap@infradead.org> wrote: > Similar to 22eebaa631c4 ("ata: pata_cs5535: Don't build on UML"), > prevent pata_cs5536 from building on UML since it references > symbols that are not present when building X86_32/i386 allmodconfig. > > ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Thanks for your patch! > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -650,6 +650,7 @@ config PATA_CS5535 > config PATA_CS5536 > tristate "CS5536 PATA support" > depends on PCI && (X86_32 || MIPS || COMPILE_TEST) How does this work on MIPS? Oh, the MSR functionality inside the driver depends on CONFIG_X86_32. Perhaps this can be fixed better for all users inside arch/x86/include/asm/msr.h? > + depends on !UML > help > This option enables support for the AMD CS5536 > companion chip used with the Geode LX processor family. Gr{oetje,eeting}s, Geert
diff -- a/drivers/ata/Kconfig b/drivers/ata/Kconfig --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -650,6 +650,7 @@ config PATA_CS5535 config PATA_CS5536 tristate "CS5536 PATA support" depends on PCI && (X86_32 || MIPS || COMPILE_TEST) + depends on !UML help This option enables support for the AMD CS5536 companion chip used with the Geode LX processor family.
Similar to 22eebaa631c4 ("ata: pata_cs5535: Don't build on UML"), prevent pata_cs5536 from building on UML since it references symbols that are not present when building X86_32/i386 allmodconfig. ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined! ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined! ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined! ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined! Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> Cc: linux-ide@vger.kernel.org Cc: linux-um@lists.infradead.org --- drivers/ata/Kconfig | 1 + 1 file changed, 1 insertion(+)