Message ID | 20230104081408.4074275-1-linmq006@gmail.com |
---|---|
State | Superseded |
Headers | show |
Series | [v2] um: vector: Fix memory leak in vector_config | expand |
On 04/01/2023 08:14, Miaoqian Lin wrote: > kstrdup() return newly allocated copy of the string. > Call kfree() to release the memory when uml_parse_vector_ifspec() fails. > > Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > changes in v2: > - only call kfree() when uml_parse_vector_ifspec() fails. > --- > arch/um/drivers/vector_kern.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c > index ded7c47d2fbe..131b7cb29576 100644 > --- a/arch/um/drivers/vector_kern.c > +++ b/arch/um/drivers/vector_kern.c > @@ -767,6 +767,7 @@ static int vector_config(char *str, char **error_out) > > if (parsed == NULL) { > *error_out = "vector_config failed to parse parameters"; > + kfree(params); > return -EINVAL; > } > Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
On Wed, Jan 4, 2023 at 9:18 AM Miaoqian Lin <linmq006@gmail.com> wrote: > kstrdup() return newly allocated copy of the string. > Call kfree() to release the memory when uml_parse_vector_ifspec() fails. > > Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > changes in v2: > - only call kfree() when uml_parse_vector_ifspec() fails. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c index ded7c47d2fbe..131b7cb29576 100644 --- a/arch/um/drivers/vector_kern.c +++ b/arch/um/drivers/vector_kern.c @@ -767,6 +767,7 @@ static int vector_config(char *str, char **error_out) if (parsed == NULL) { *error_out = "vector_config failed to parse parameters"; + kfree(params); return -EINVAL; }
kstrdup() return newly allocated copy of the string. Call kfree() to release the memory when uml_parse_vector_ifspec() fails. Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- changes in v2: - only call kfree() when uml_parse_vector_ifspec() fails. --- arch/um/drivers/vector_kern.c | 1 + 1 file changed, 1 insertion(+)