From patchwork Fri Oct 29 02:47:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 1547761 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=gpFGKf7S; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=jvF0DzL8; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HgRfq5vY6z9ssD for ; Fri, 29 Oct 2021 13:47:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1LZIuka9AgWIZxRCmoaId/RsfBoiniGvJNVU2pNYPxc=; b=gpFGKf7SLqyeCp mW40nwiMEItxQK46tgImboHsybMFEWsCshnGtsENRo9QaTbrJKFDT9GZxJ8HNzOM2NaRoggdBVPaw zm/UxpIb1GjL2AMZhg/LpNPBYxxXa4E581fsWHb+qeycHuYobGcu9y/j5iz8s6nFS+XhYtGFyUlYi wj8AVNAcmyRZaQ+RZys7mQ43xq46pYc8nQYJULxL3vdoGeFqMMRZZTOYDeMX7T17RIF8eTACnhj8F 0w01ZDUozdm1zf0PoGKceK2Obu9/qS0pmO2bucnwsDt9pzwYc5QRF/8HjXL4V9B1cQ9bvK2i6kpjf +4OSwSbs9P+LBOuTlUoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgHvJ-009b7X-5M; Fri, 29 Oct 2021 02:47:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgHvG-009b6H-F8 for linux-um@lists.infradead.org; Fri, 29 Oct 2021 02:47:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2617861175; Fri, 29 Oct 2021 02:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635475633; bh=tiMVZ2XyRVbORniU+vtW0g1IFv6IL3znQKoUPUMCTIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jvF0DzL8BaGh+RxlEhqAinVDifdP1rnwBubvubniCLq+jD1TakXUu9rMSxXO/1OrA 9Y5WpWNjj8v9sXrc89QUVnn7u6nSSFObb+0ZVK/ZzuchYLrUFwm8A2I4Gvy6WLOUq8 QKsjg67iqydQ+ZT3wV2sT9uzhfOl3P7lexKsQVih4xC6W23jGPk9q+ZuWSdkSfrFNv RpKmsv11rmuG2Zw5qc4H5BANlxr4OwEvB4hZHj78dP5vLntyk+AxUCMpiQQczxIQGf mk/WV6U2J3anA4108im43wXDD53hfchDLJDFbJqZtLRRrutCWxeWTub06SQmhoU5M0 5PukDNbv+MDHA== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, Jakub Kicinski , jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes.berg@intel.com, linux-um@lists.infradead.org Subject: [PATCH net-next 2/3] net: um: use eth_hw_addr_set() Date: Thu, 28 Oct 2021 19:47:06 -0700 Message-Id: <20211029024707.316066-3-kuba@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029024707.316066-1-kuba@kernel.org> References: <20211029024707.316066-1-kuba@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_194714_572086_E9CD0268 X-CRM114-Status: UNSURE ( 8.51 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -5.4 (-----) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Commit 406f42fa0d3c ("net-next: When a bond have a massive amount of VLANs...") introduced a rbtree for faster Ethernet address look up. To maintain netdev->dev_addr in this tree we need to make all t [...] Content analysis details: (-5.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Commit 406f42fa0d3c ("net-next: When a bond have a massive amount of VLANs...") introduced a rbtree for faster Ethernet address look up. To maintain netdev->dev_addr in this tree we need to make all the writes to it go through appropriate helpers. Signed-off-by: Jakub Kicinski Acked-by: Anton Ivanov --- CC: jdike@addtoit.com CC: richard@nod.at CC: anton.ivanov@cambridgegreys.com CC: johannes.berg@intel.com CC: linux-um@lists.infradead.org --- arch/um/drivers/net_kern.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c index 2fc0b038ff8a..59331384c2d3 100644 --- a/arch/um/drivers/net_kern.c +++ b/arch/um/drivers/net_kern.c @@ -276,7 +276,7 @@ static const struct ethtool_ops uml_net_ethtool_ops = { void uml_net_setup_etheraddr(struct net_device *dev, char *str) { - unsigned char *addr = dev->dev_addr; + u8 addr[ETH_ALEN]; char *end; int i; @@ -316,6 +316,7 @@ void uml_net_setup_etheraddr(struct net_device *dev, char *str) addr[0] | 0x02, addr[1], addr[2], addr[3], addr[4], addr[5]); } + eth_hw_addr_set(dev, addr); return; random: