diff mbox series

drivers: gpio: AMD8111 and TQMX86 require HAS_IOPORT_MAP

Message ID 20210625103734.2f29630be607.Ied890c9ca650517103410e399ef509796653f5d3@changeid
State Not Applicable
Headers show
Series drivers: gpio: AMD8111 and TQMX86 require HAS_IOPORT_MAP | expand

Commit Message

Johannes Berg June 25, 2021, 8:37 a.m. UTC
From: Johannes Berg <johannes.berg@intel.com>

Both of these drivers use ioport_map(), so they need to
depend on HAS_IOPORT_MAP. Otherwise, they cannot be built
even with COMPILE_TEST on architectures without an ioport
implementation, such as ARCH=um.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 drivers/gpio/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bartosz Golaszewski June 25, 2021, 10:16 a.m. UTC | #1
On Fri, Jun 25, 2021 at 10:37 AM Johannes Berg
<johannes@sipsolutions.net> wrote:
>
> From: Johannes Berg <johannes.berg@intel.com>
>
> Both of these drivers use ioport_map(), so they need to
> depend on HAS_IOPORT_MAP. Otherwise, they cannot be built
> even with COMPILE_TEST on architectures without an ioport
> implementation, such as ARCH=um.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  drivers/gpio/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 1dd0ec6727fd..3c69b785cb79 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1383,6 +1383,7 @@ config GPIO_TPS68470
>  config GPIO_TQMX86
>         tristate "TQ-Systems QTMX86 GPIO"
>         depends on MFD_TQMX86 || COMPILE_TEST
> +       depends on HAS_IOPORT_MAP
>         select GPIOLIB_IRQCHIP
>         help
>           This driver supports GPIO on the TQMX86 IO controller.
> @@ -1450,6 +1451,7 @@ menu "PCI GPIO expanders"
>  config GPIO_AMD8111
>         tristate "AMD 8111 GPIO driver"
>         depends on X86 || COMPILE_TEST
> +       depends on HAS_IOPORT_MAP
>         help
>           The AMD 8111 south bridge contains 32 GPIO pins which can be used.
>
> --
> 2.31.1
>

Applied, thanks!

Bart
diff mbox series

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 1dd0ec6727fd..3c69b785cb79 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1383,6 +1383,7 @@  config GPIO_TPS68470
 config GPIO_TQMX86
 	tristate "TQ-Systems QTMX86 GPIO"
 	depends on MFD_TQMX86 || COMPILE_TEST
+	depends on HAS_IOPORT_MAP
 	select GPIOLIB_IRQCHIP
 	help
 	  This driver supports GPIO on the TQMX86 IO controller.
@@ -1450,6 +1451,7 @@  menu "PCI GPIO expanders"
 config GPIO_AMD8111
 	tristate "AMD 8111 GPIO driver"
 	depends on X86 || COMPILE_TEST
+	depends on HAS_IOPORT_MAP
 	help
 	  The AMD 8111 south bridge contains 32 GPIO pins which can be used.