diff mbox series

[v2,2/2] um: time-travel: return the sequence number in ACK messages

Message ID 20200910113049.bb7bf508a6ad.Ib2bcca1371247b2f8643f35fb85ca5051addd8cc@changeid
State Accepted
Headers show
Series [v2,1/2] um: time-travel: fix IRQ handling in time_travel_handle_message() | expand

Commit Message

Johannes Berg Sept. 10, 2020, 9:31 a.m. UTC
From: Johannes Berg <johannes.berg@intel.com>

For external time travel, the protocol says to return the
incoming sequence number in the ACK message to aid debugging,
so do that.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 arch/um/kernel/time.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Anton Ivanov Sept. 16, 2020, 7:30 a.m. UTC | #1
On 10/09/2020 10:31, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> For external time travel, the protocol says to return the
> incoming sequence number in the ACK message to aid debugging,
> so do that.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>   arch/um/kernel/time.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/um/kernel/time.c b/arch/um/kernel/time.c
> index c07436e89e59..3d109ff3309b 100644
> --- a/arch/um/kernel/time.c
> +++ b/arch/um/kernel/time.c
> @@ -106,6 +106,7 @@ static void time_travel_handle_message(struct um_timetravel_msg *msg,
>   		break;
>   	}
>   
> +	resp.seq = msg->seq;
>   	os_write_file(time_travel_ext_fd, &resp, sizeof(resp));
>   }
>   
> 
Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
diff mbox series

Patch

diff --git a/arch/um/kernel/time.c b/arch/um/kernel/time.c
index c07436e89e59..3d109ff3309b 100644
--- a/arch/um/kernel/time.c
+++ b/arch/um/kernel/time.c
@@ -106,6 +106,7 @@  static void time_travel_handle_message(struct um_timetravel_msg *msg,
 		break;
 	}
 
+	resp.seq = msg->seq;
 	os_write_file(time_travel_ext_fd, &resp, sizeof(resp));
 }