Message ID | 1829585.6m1bt7BjAO@blindfold |
---|---|
State | Accepted, archived |
Headers | show |
Series | [GIT,PULL] UML changes for 4.20-rc1 | expand |
On Wed, Oct 31, 2018 at 2:22 PM Richard Weinberger <richard@nod.at> wrote: > > - Removal of old and dead code > - A bug fix for our tty driver > - Other minor cleanups across the code base Pulled. I may not like recent rebases, but I do like this: > 11 files changed, 19 insertions(+), 456 deletions(-) > delete mode 100644 arch/um/include/shared/aio.h > delete mode 100644 arch/um/os-Linux/aio.c Thanks, Linus
Am Mittwoch, 31. Oktober 2018, 23:48:07 CET schrieb Linus Torvalds: > On Wed, Oct 31, 2018 at 2:22 PM Richard Weinberger <richard@nod.at> wrote: > > > > - Removal of old and dead code > > - A bug fix for our tty driver > > - Other minor cleanups across the code base > > Pulled. I may not like recent rebases, but I do like this: Okay, so my rebase was in vain, I thought you don't like pull requests with such an old base. Thanks, //richard
On Wed, Oct 31, 2018 at 4:01 PM Richard Weinberger <richard@nod.at> wrote: > > Okay, so my rebase was in vain, I thought you don't like pull requests > with such an old base. Some *really* old bases can cause problems, but generally that's if it's more than a year old (or if there's been some major upheaval that happens to particularly strike your particular code). Honestly, I don't think I can recall any actual "that is based on something so old that it actually gets problematic" case ever having happened. But I could imagine it. So if it's "a release or two", it's not worth rebasing for. Not unless there is some other pressing reason (ie some screw-up that requires a rebase). Linus