| Message ID | 1630655468-71684-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next] um: virt-pci: Fix the application of sizeof to pointer | expand |
On Fri, 2021-09-03 at 15:51 +0800, Yang Li wrote: > sizeof() when applied to a pointer typed expression gives the size of > the pointer. > > Clean up coccicheck warning: > ./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to > pointer > > - memset(data, 0xff, sizeof(data)); > + memset(data, 0xff, sizeof(*data)); Oops. I guess I only tested on 64-bit where this is the same, and in fact on 32-bit it also wouldn't matter since you can't even do 64-bit reads there :) A Fixes: tag would be nice, but otherwise Reviewed-by: Johannes Berg <johannes@sipsolutions.net> johannes
diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c index c080666..156af2f 100644 --- a/arch/um/drivers/virt-pci.c +++ b/arch/um/drivers/virt-pci.c @@ -189,7 +189,7 @@ static unsigned long um_pci_cfgspace_read(void *priv, unsigned int offset, buf = get_cpu_var(um_pci_msg_bufs); data = buf->data; - memset(data, 0xff, sizeof(data)); + memset(data, 0xff, sizeof(*data)); switch (size) { case 1:
sizeof() when applied to a pointer typed expression gives the size of the pointer. Clean up coccicheck warning: ./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to pointer Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- arch/um/drivers/virt-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)