From patchwork Tue Sep 4 02:44:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965690 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KnWexuAD"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LSyhtXkG"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6D6lr4z9s4Z for ; Tue, 4 Sep 2018 12:45:56 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=XRlBu359RTyJ9+yEwj9k+gItadesZOdb8o7hvnZBc4U=; b=KnWexuADrjUyhFhcee0koevWEO Fy30n2LtXNtzBGBDVeI8jEg1mbjROwa+rSnMvZWXVUER71gEom/ipwVrU1+TRRibdDplS5K2rA7g6 ZPBwfWAG197c1lTWM30swcVUMpYjb0zQ5wzvoDxUwHOHF7R1MUC8mZYHNY5kMJt3FWGWg9uUzwKIs oLtRRmqDwWLRkMnoC2jXFd6VMmBOmBqGev6KnPgt1WBfR365NO9vFn22ZCWbcjGA5nnj7YAl2BV87 b/zvI8E2fczN3MqOr+4N+NELGVdHRnaeWOeR78oIrwDTSCoxfs3rUUzC7qPFoV4Ah10I0hvXfL1w7 9AeWDmvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Li-0005Pz-7u; Tue, 04 Sep 2018 02:45:50 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Lf-0005LF-2c for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:48 +0000 Received: by mail-pl1-x641.google.com with SMTP id d9-v6so899383plr.2 for ; Mon, 03 Sep 2018 19:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5dM0xQ787rzw6bkqyfUjT3zjhB0YPJAJ51j5bAjS2T8=; b=LSyhtXkGxa0FU0fVjsQpau0if65BJFmvzTCCED/yoMtBCsWTOnczf44bQOG4WVD3fk bT5CCAsnyu0hAMzH85mdtgxH14TdL6PUQ1zver7BZy05sFf+wiPf/8I+q/7zE38P/9Jd IhyNrZV6oM9k8dcP2bJRKaTsooiRxqt9q7/8AgVMWoxqLoV/Hz8djpSqpBqpqZJmvQxQ 3FrLn2wBuQCXyxmN+IqBghprw+qPZeipg8ugBJVDSlOIm3/nRW0IkuAg8ycUsP8MrpIX TqWth4eQahCzAXARFo70j1Tvdj5cgsBSWRmX6jbV1gMaL44/FiWoFnrJSyklXMgO4wkq QXBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5dM0xQ787rzw6bkqyfUjT3zjhB0YPJAJ51j5bAjS2T8=; b=lEf/Y/CBqAavLqiAuCZi1lHn6/qqSUnSh0slh165lzx4p0N2iySksjEN34VilHDK7l J6DHq/okhAKb3/kNk1NcFp4PzdwoIpPN74DnrOAGwrdBLE6i1GUsnn4pZiD589XxvZMM 7+LsIrSEn0i2NiyI7h+qR/fqmN61G4Wf55YqCaqDGrFkuru7Sd497axl2mar+T5Pdjda gnAidTZKJNZiMaSqP/LGTj61EjMbQ+vXjtIxu9FdiNoQyh5VSfi+ZkNeUJbKfzP11ZPP idOljPHPXME+v52wXvEux0cU8Xk8aEV6m7yL/J7CXgJ5XOqfuefUPPLZJWv3luUkRJJ/ NKpA== X-Gm-Message-State: APzg51Cr3B73KB4um04xy22LD8HgVsDT2PrehZHGv7zSgcrNG1efwlvZ CvAJ5nO8Z4zb2IbUznPp3am0DKXQ X-Google-Smtp-Source: ANB0Vda07x392kbhxT9E/C+zoKxcW85Bqrj63tRUL/LAuoI3BB2I0JaA0GyiQM4GxiYzWJUg3ATX1g== X-Received: by 2002:a17:902:b68d:: with SMTP id c13-v6mr26735699pls.139.1536029136410; Mon, 03 Sep 2018 19:45:36 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:35 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/25] tty: n_gsm: Change return type to void Date: Tue, 4 Sep 2018 11:44:34 +0900 Message-Id: <1536029091-4426-9-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194547_122133_58CE87DC X-CRM114-Status: GOOD ( 12.95 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:641 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/n_gsm.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 86b7e20..c52fa2d 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -2917,7 +2917,6 @@ static int gsmtty_install(struct tty_driver *driver, struct tty_struct *tty) unsigned int line = tty->index; unsigned int mux = line >> 6; bool alloc = false; - int ret; line = line & 0x3F; @@ -2949,14 +2948,8 @@ static int gsmtty_install(struct tty_driver *driver, struct tty_struct *tty) mutex_unlock(&gsm->mutex); return -ENOMEM; } - ret = tty_port_install(&dlci->port, driver, tty); - if (ret) { - if (alloc) - dlci_put(dlci); - mutex_unlock(&gsm->mutex); - return ret; - } + tty_port_install(&dlci->port, driver, tty); dlci_get(dlci); dlci_get(gsm->dlci[0]); mux_get(gsm);