From patchwork Tue Sep 4 02:44:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965684 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FXglXWIU"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VCPVzREE"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B604ztRz9s1x for ; Tue, 4 Sep 2018 12:45:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hxDDKt7bTBx/vR3YXfexySyr40eMY+gVI3l3dtAKCug=; b=FXglXWIUXo0xJzPMy+c+p/ayQj vjozPt85Jo8eGiolNch+mHxTmp8cLZY5e8cneJtwbTSI3+GR6/CbeIZlRazjNkn/xtNxmtWhuBHqh BjDAL3g10Ky963CjMX0hn3b41bE1TaLp0RM3DM8KGi2QPO6shZ6eKei7vVaprXoSWZx93Xfn6wn0b FNNjGTE/A1CRcLfopyDpyqBSCYpohNj5BKF/AdcCf5w70JBwXcdK6iJ9aalUGGTThfZo7AE+YgSIT ZUA3+KGJOYMJJ6FwGIL+E8VK3YO26JMrA7ffvD9nWJAFDQ5pizUWDPjJSQvxOemFIwE71yXGkkPai n8FKki3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LV-0005La-95; Tue, 04 Sep 2018 02:45:37 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LR-0005GC-Nf for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:35 +0000 Received: by mail-pf1-x443.google.com with SMTP id x17-v6so910752pfh.5 for ; Mon, 03 Sep 2018 19:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3hQFNTER0lszd0kvVWEV9kMR5sWuq9dK2/YVDi+Idr8=; b=VCPVzREENBfb8A3S3qPc2w/U09HYMnR5XjohbR7s87xH2founlXnJ7O2LxYkSefiuq KsuC0X422xiff0z0Rlrk4+ofOXd4g1EIaYHnlxpKKNux/l7AB3XHg9KKsOkO4P07Rws7 hJqi7OObHxBUF2Mb0q1XpiUSrvJegONnM4mZZULdG//xUDPAczorNWMFdhEoAN8mkd5r FXPlZvM7PP2RPTnM19wOnLaGM3+bSK/bN3CM40wstgm9dcjsSGP2xDJoovFMHtcNciL2 nPsZIRvd8rg0a4e6qnnO4JXKdGmmAlU++jWLQRlXmfQntrU61+HuBTGxUIK1fUCwTDtz RVng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3hQFNTER0lszd0kvVWEV9kMR5sWuq9dK2/YVDi+Idr8=; b=JyGfGYGXRwrjgnL/PKQTC3WCPzxb5z+wP7CrrOBt2WD3BR4FT9QKdhhrv6fKiVMGcv aJV2oqJSOIAG9Ky0upJND6x72S8f3rhCGa9HHUTrmkjRTNGeTjuCj/wEUoFRrvz6EOp6 VQ/JT/PT7xaYYUTePekgiWGSvgiu0oii7ubC6lmPuRXUXO1qkQPYYc196xxykUkzKd6I e85IbMw6J97lnUUtTcjLaxRh7JY1SxepE9S06k072egxOTnDjMHlh7en5tMf0+MyUArX cC4TA2yMGpjJSANiPtKXgeG7rdgAuwjGWslEpDXt65YsRSFX7vY5gxfiYw7yFTDAw7TQ ZqZA== X-Gm-Message-State: APzg51Dr+SZoPNLJJgX0Ew77cMPNR+4dNsw0ZlM2f/kc0Iu6OUFz9VUB DBZcGbtFQ8kMdCHuUuz8ak88Y/B4 X-Google-Smtp-Source: ANB0VdZGhGrOBh/Fz1lvUWCqJiTMNZnM5DkgqzgQGJrQBIlWSPsVG9V2HnHzIfB07WhBfG8nk/v2/w== X-Received: by 2002:a62:6003:: with SMTP id u3-v6mr32916616pfb.114.1536029123060; Mon, 03 Sep 2018 19:45:23 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:22 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/25] tty: hvc: hvc_console: Change return type to void Date: Tue, 4 Sep 2018 11:44:31 +0900 Message-Id: <1536029091-4426-6-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194533_809938_FFD1D92A X-CRM114-Status: GOOD ( 12.94 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/hvc/hvc_console.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index 5414c4a..13fad62 100644 --- a/drivers/tty/hvc/hvc_console.c +++ b/drivers/tty/hvc/hvc_console.c @@ -329,7 +329,6 @@ static void hvc_unthrottle(struct tty_struct *tty) static int hvc_install(struct tty_driver *driver, struct tty_struct *tty) { struct hvc_struct *hp; - int rc; /* Auto increments kref reference if found. */ hp = hvc_get_by_index(tty->index); @@ -337,11 +336,9 @@ static int hvc_install(struct tty_driver *driver, struct tty_struct *tty) return -ENODEV; tty->driver_data = hp; + tty_port_install(&hp->port, driver, tty); - rc = tty_port_install(&hp->port, driver, tty); - if (rc) - tty_port_put(&hp->port); - return rc; + return 0; } /*