From patchwork Tue Sep 4 02:44:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965730 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SGUzoa6P"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MtxqNB0W"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7f74CZz9s3l for ; Tue, 4 Sep 2018 12:47:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=RJ++KzIO00m1UcO6Cq6C0THaxiCHJVPknQB6rTGCPco=; b=SGUzoa6Pstpi4pxEnOlF1cVuzC UZCBrjLdUCfCGg+98y0ulnBORi3S6PFGPHnFbUNWuoYHXL3BN9Q/9Q8yiUqk6um1TaTxF2eikb/MT /2HeyvzjUUt2/vfmb2mtKt9mRowmlweNsC7n79ApVavDbnzjjIQ7XjLRTOT4AwvY4tQ8Sh29Orqjl HDOjkrGfHrP4u1PSmES9WwviL0KcjNYjZB95hHTf8tBK8UQb5v2J5Vn/5XZfHad6N76KdQsnrPDmf A6haKZqy97EInoVI077hrOzXk9CTr8BMHXm9n+mK4ERLgYwMcQ0pF+zaQ95gBLqoX9y5PWHCazMYi 4GE9yPHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mu-0005re-BA; Tue, 04 Sep 2018 02:47:04 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mq-0005oK-Vo for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:47:02 +0000 Received: by mail-pl1-x643.google.com with SMTP id g23-v6so879765plq.9 for ; Mon, 03 Sep 2018 19:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9fhtRSxRNlhSG2HakM/avAOwn2fzs7e/3lLxQzyJ82M=; b=MtxqNB0WA/xheF8oer5OfxpHH+cnB/mFS5n9FY2+qIngoXU2LN6P0ny5VhtK1xJhbi D8ATKUqQvESgCYvBa6wJ6P1rAN1s01M1QcKskSibu61DVOa0RoiUs83RTrNmu6/XM3NW bynC2ACo8vSZJxZUSDYPOxFnJiOcAGHWocCRm3KiTyJnbMpu3iXC9GrWS+ngdbYg/XnI GbBvce2BsHGIHsbrP2tub+g789NyfsB1vl3vkW2Z+pDQ0wOXDIgtgeK9WuRRzrjxrlWP fXusYtUOTBC/xkFSb4wmIPQ1bQQSy3UkX8Ww52YENeadayXKav0ZMV2ImRPxm5eDFmR5 8Nig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9fhtRSxRNlhSG2HakM/avAOwn2fzs7e/3lLxQzyJ82M=; b=YaWvAU5oXXlm28Wxc0jMZtI6lZOiEuKkoCdFcVJ0x1tf3dwu4KMF5mKmt9NT1Drcq6 DcxkcP0AMWCJR9qp52wll7s4ucfbApF1LbJczpiWWKSvIAkh0Ig1whhgfgzGL38JJq65 uw3rRJMgqtXxjCf/kBnDXzFLd1keFNoyOQ6SgidE6XK0e4SYMGJoF0xQLbZJI8VglLeA jWpNo7AVmjqPHBHRGbSPLXPLUfN/AiMGkSI4JdAu5lD7Bqyx0/a/XBx6HmI28VSvVpGd MNXanY292F0ZOYuG6hp84aEJ0Ir3Lsv7SdATA5g+yqE9OISzSJWKBFU//aBRrEKHQHC5 3yLg== X-Gm-Message-State: APzg51CfIyoDT03DlFFoEIw+Ue6xZnwO8mmIIp/3V6zrT4ThR2NbkZZX e2ExVqZWG3i8ovBWH+QMOSYBmJ5J X-Google-Smtp-Source: ANB0VdbGNWdoDZT7cp5uWkjz+NRP9RQkbF+dv0PEH/mUMC3Ps4V7vhtxolhlceX7nOpZVgYGv2eimA== X-Received: by 2002:a17:902:bf43:: with SMTP id u3-v6mr31343352pls.88.1536029214501; Mon, 03 Sep 2018 19:46:54 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:54 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 25/25] usb: usb-serial: Change return type to void Date: Tue, 4 Sep 2018 11:44:51 +0900 Message-Id: <1536029091-4426-26-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194701_030589_2A9F579F X-CRM114-Status: GOOD ( 12.15 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:643 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/usb/serial/usb-serial.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index f7aaa7f..5cfc2ca 100644 --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c @@ -192,9 +192,7 @@ static int serial_install(struct tty_driver *driver, struct tty_struct *tty) if (retval) goto error_get_interface; - retval = tty_standard_install(driver, tty); - if (retval) - goto error_init_termios; + tty_standard_install(driver, tty); mutex_unlock(&serial->disc_mutex); @@ -206,8 +204,6 @@ static int serial_install(struct tty_driver *driver, struct tty_struct *tty) return retval; - error_init_termios: - usb_autopm_put_interface(serial->interface); error_get_interface: module_put(serial->type->driver.owner); error_module_get: