Message ID | 1536029091-4426-25-git-send-email-climbbb.kim@gmail.com |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sK66SNYM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Bx65hI3S"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7f5nVqz9s1x for <incoming@patchwork.ozlabs.org>; Tue, 4 Sep 2018 12:47:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=QWiv06AGwQwYFEYvvZvHrPG/AfWF728DPUaRP6iqWnM=; b=sK66SNYMfX59O/d893/qiPDt5z D7GC+4FEXtg1Z+7NPW42XDToYfWNMjBh4DCYS2fkwO1fufPPYFka6o07S4+XtT9ncePRuMZVCQB0a Maqyej1EWZ/WOFJN4Q3ipUqYQpY1sowYSfysP9ai8SjpPIuBGNSgV74zB/2ZhLFzoOx2szp63Uy3w iIB/0q3FxVd0U7oQ93VdNquviYShZtYyajpqcAyvhtTNRudQTBKlsh78GqBTmOKlCk8mfU8GtDMNC UYhKWfe0NezP793t69mHUMCyzKgiWlba11eBCWa/wtnqfMu87GRxqck9XyV/TPI1QORlapSUWnigy 16gYUVWw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mu-0005rq-I9; Tue, 04 Sep 2018 02:47:04 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mq-0005mZ-Vv for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:47:02 +0000 Received: by mail-pl1-x643.google.com with SMTP id f6-v6so898159plo.1 for <linux-um@lists.infradead.org>; Mon, 03 Sep 2018 19:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RZT0NlqWPDVv3ZY8knEZ75oaH0KEYhTsNL+EUjOlpgk=; b=Bx65hI3SeSwju/CMQO3BmpKV5KW3A7z+7x59hC7W08nF3mou9O0IAO/i26QCK1SAav qpfO2abtOD1tOU1XvV39t4Q66+miH6hx+lYSF23Ln0nFrCHq6t8OIrZnakB5FyLMpQiH JJbcCQrzro3jr14467jxQwj+fnbPp3AgA6AxS4KK3OzwSFIx6TP3gru3F2vgX11T2QEM 1nLcSdwTN3OCx3Q5+P6ERKE2TPj2LnR7jH5tNKM10h+UoUDk19KW4qxVB9vlt8pOjJ49 y4INNwqDe5rIv/tQK3LyH/Y8Q7kVNPecJm2Do/86YjEud3mWKeOnzqtFVw73hq9OdWSV uINw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RZT0NlqWPDVv3ZY8knEZ75oaH0KEYhTsNL+EUjOlpgk=; b=r7M/znKogJadgA5Ouk1jZK275GhbfwSlAe5jdUT1wE6d0hP5PQ6Aee0WvAODFhoO5k NuWpMZoPZ4fhtX+d5KzTJOnTmIdhokxvBUBgl+aR9K9rb2gTFerGuOMFc3QskZ5XDFRG VEpDcmHsb9EU9FTosAS+uGJDIe54eUax2WLmKgdNrzQh4I5XInfzf2g67LN753DU2wzM Ge34L2BqWEX6hPylxy3wbTphzfV6VCg0lYeRErkzcZ1p2sSQAOC6n3e78JL2XUU1lXBY f6z3YMC+7GZGbhg4sZaAPRi/oIcqDILpR0mkCg7HHAsqwNVkmIcjXfF+ZF4V7/+Ubu/v 5TFg== X-Gm-Message-State: APzg51BAJhDI0UB5HLeN4VV57QNA5Y5ELmVpyM4i66C8KjEIbM39e4yS FxrIYMoTjirSSOuqPoiRm/7Y9PTX X-Google-Smtp-Source: ANB0VdZdWeaAIXAcMtwyECEthciNo7IoqHV1eYwdRbpGaJEZKNxxUYIv88HfBs7dyZgV+Zaswfxqaw== X-Received: by 2002:a17:902:2e83:: with SMTP id r3-v6mr31398676plb.80.1536029210221; Mon, 03 Sep 2018 19:46:50 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:49 -0700 (PDT) From: Jaejoong Kim <climbbb.kim@gmail.com> To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 24/25] usb: cdc-acm: Change return type to void Date: Tue, 4 Sep 2018 11:44:50 +0900 Message-Id: <1536029091-4426-25-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194701_035365_6F47DB85 X-CRM114-Status: GOOD ( 12.75 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:643 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-um.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-um/> List-Post: <mailto:linux-um@lists.infradead.org> List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=subscribe> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" <linux-um-bounces@lists.infradead.org> Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
Change tty_port(standard)_install's return type
|
expand
|
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 27346d6..de6a27e 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -572,23 +572,15 @@ static void acm_softint(struct work_struct *work) static int acm_tty_install(struct tty_driver *driver, struct tty_struct *tty) { struct acm *acm; - int retval; acm = acm_get_by_minor(tty->index); if (!acm) return -ENODEV; - retval = tty_standard_install(driver, tty); - if (retval) - goto error_init_termios; - + tty_standard_install(driver, tty); tty->driver_data = acm; return 0; - -error_init_termios: - tty_port_put(&acm->port); - return retval; } static int acm_tty_open(struct tty_struct *tty, struct file *filp)
Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com> --- drivers/usb/class/cdc-acm.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)