From patchwork Tue Sep 4 02:44:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965726 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S9S8+Qo8"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="D+huqxdj"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7V6hTHz9s3x for ; Tue, 4 Sep 2018 12:47:02 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=xUztPCdLNyJ7y552mm0T66gceMon0q2TExdi+tHfN0Q=; b=S9S8+Qo8xlkwIvw7Z/Z6X36OfY kw7njFzKH+4xA5/qliioLoeB2E08X87RDPGyRYRp3RCYpaVut7aJkj1nsMccjRrspk8XuCeFdSDuZ 84pmZldGG5rOrrU2/iSU6ZxaTlj/QXxR27kM9zBMOTjxaulAWK/8o0nwzByx4D6WX9O4xFTTHzeeH MQDNyWlVoMHQiInxSm6czaDHeYuqa+0Bfwvj9RdVj+Z2nGp/9K4WGN+U2uyidciAPUxiZj00iYAkS JnZsA0KOiyFDgffDfnKHp7kkfsjFrQR7tIR1Pom5+ttl/Dtx4lqW6Hv5kl5Ic3jlX98/R1JXf4Ghb SnPWKxuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Ml-0005oR-Ob; Tue, 04 Sep 2018 02:46:55 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mh-0005ki-QP for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:53 +0000 Received: by mail-pf1-x443.google.com with SMTP id d4-v6so925208pfn.0 for ; Mon, 03 Sep 2018 19:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K9WSdI4xIWm95WefIAgmlM2Cw4JjRPctJYgLLWJhf3w=; b=D+huqxdj0oLB5H6zpdMf3v6ziDrrSw7vKzugFiDWga6u43eI5eNN/AeuWIFSjMThV9 o+kwP6EcS1+2s4zSPclms+ESo7BcUX+xwM7XTXCiTMUhlXvBUqGdQphSmbym5oWRD8Vx ufgvcSMipW2mSpNiGcoJ9rSO8nQ2Z9NXG44kZ60XZmViRjD5s3rrHr2JvPYGHB0PYvrr FdZCUz/9fOc+BUUX/stpxBBG0qb0SohURfo3prJ7eDmcIxBVXy0g2U4k8HFyAxsbYN7x TAKYgQoLGJG4qUZG4igX5NrV8+v/Cpk31DoUhNJIeSdhMsqONJLWCMpQmWJ3JiGcBkW6 bjzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=K9WSdI4xIWm95WefIAgmlM2Cw4JjRPctJYgLLWJhf3w=; b=IixIlfxpY/fxz53hMZXDYh47T0yvrgarAXYDrloMakNfzC/cnugksXZ49ivBXJqA4m /9pCyRzvIY0a0w8hwn/UBZkCY7AGHY0HmmWhgLKYH0vJguc5boF/q/l58ofJO3n/xxMb coXAFbyP2jOuMOA7kvcnyoW5m1XjWUevQjW4jJA8yQh56ZMUfy6i/B1ymuJKmvJ5SL5O Z07KOjc2LtsICLj5V9KU2WaCc/G5QnDVlOWpjSd5AB+yXF2y00CnnGAa3nFcOXUQf+5v xAjPHX1ohd17krtaJU461s7yzhRhQmu6APVrxR+AztQV0VXS+U3cI+iu0xpm0LZpj4Fo gn1A== X-Gm-Message-State: APzg51A84xMoMz9s7md2HRWFO9Lr4I1cJriKgKL3ZaFumtTbQDa/hJ4s 3f1eMBJ4hl7FZzIJ9bJMLmmbUus9 X-Google-Smtp-Source: ANB0Vda9K++B22N8xLV0SZkONnEg8X/QNN1vt5G5oV0BkvA8DNalLdyDj9o6GaGtgd/VNljMAEqiZQ== X-Received: by 2002:a63:88c8:: with SMTP id l191-v6mr29118195pgd.340.1536029205367; Mon, 03 Sep 2018 19:46:45 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:44 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 23/25] tty: vcc: Change return type to void Date: Tue, 4 Sep 2018 11:44:49 +0900 Message-Id: <1536029091-4426-24-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194651_913837_41A38282 X-CRM114-Status: GOOD ( 12.09 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/vcc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index 58b454c..ce32631 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty/vcc.c @@ -987,7 +987,6 @@ static int vcc_install(struct tty_driver *driver, struct tty_struct *tty) { struct vcc_port *port_vcc; struct tty_port *port_tty; - int ret; if (unlikely(!tty)) { pr_err("VCC: install: Invalid TTY handle\n"); @@ -997,9 +996,7 @@ static int vcc_install(struct tty_driver *driver, struct tty_struct *tty) if (tty->index >= VCC_MAX_PORTS) return -EINVAL; - ret = tty_standard_install(driver, tty); - if (ret) - return ret; + tty_standard_install(driver, tty); port_tty = kzalloc(sizeof(struct tty_port), GFP_KERNEL); if (!port_tty)