From patchwork Tue Sep 4 02:44:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965721 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lA9Yu3tq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="i5E4+keX"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7J6ljmz9s47 for ; Tue, 4 Sep 2018 12:46:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Ox0t32ABFlh8Dx1tPK6NVCJrEezTU/XDAjeFAP/IXZo=; b=lA9Yu3tqE7tqr1AEvNkFYt7Eky l2h8Xn3NwmCHuwfp1p51EUP9tPUpqlXFhX9xt4tqHwLw6JgD7Xxw2MiWTR61Vq2ZMZmh0tT8aUaAy o1AkfXZtKpxlDOwkVxum4kF7sI7B9o4Gk7nWNBSnoJtAYiA35CevkNBNQIXwRCL75pGDdFGmlYJKd b+qPFhTLoEGo5JLZ8LWWle7Q1MP4oq7OFNh+tBxapmO+qVwEUNRVUSiutc09E1Azs8NVtAzpNM7y6 DrXRfWAhWoJNczQAetYejWrEtzJvRSLFl8P3zKIoDfNkzkmi6Da663U2pqO7E1xvqpmYxfeKJ47Jw nQYGbT7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MW-0005j2-2o; Tue, 04 Sep 2018 02:46:40 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MT-0005dr-JH for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:39 +0000 Received: by mail-pg1-x542.google.com with SMTP id r1-v6so874004pgp.11 for ; Mon, 03 Sep 2018 19:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oYYQC2lkr9IQJTqeFD66xCNBcnWgOnsYuLXK//u2PDE=; b=i5E4+keXmQBCY2tQQzXatN2SdOHTlREsIC2+XC3mh7qBzlx2WNNYNE0ijaHVZFriGl 88IRFrIVlEnSux5+Mv5/5qPauDnpX0snK9IXMtVXPruvoRDXOmSI7A3u2//m6KrAmc+G CTa1NBlfR1of5pEi57kQcdEalChJGL//o8ka4X+7sh0RdNWrNhi2++Trmp0jDYrr/CgZ NkCKhgr2M/5Ec/n/10/ThXf0vIpkSHtsXVOB4oObVNNfAujltW+5vbvG/UreNjb4uGRa YvIMOQegFuZlBA59IKqnuJisn/u2nWiEKUHLcqGNye2/jpRawhFV6Mhv41E/55XdW98F FkVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oYYQC2lkr9IQJTqeFD66xCNBcnWgOnsYuLXK//u2PDE=; b=h5qISvUStq0xLL0Ibj+Kr4+KPaXwdcNH+kr0aFvQxb8axwVgqz1V4hxa5b1arjN1UQ Uo23G16jX9v0FiSccJ/UfPL1Uf9n+9wjVGXjpqfZI8lerunelZ8stLxhukM9LIkfRZBZ cWYab7HZKHEiFpTxGlzPMlM8l0kyqdkWf7CPt6fTEpFhObpwe0DgebVo1syhxx70dN4R LOR3E8lsurJe3MCVOs53Yex9zAsgjuUEr1LKoMq3E9NJT1WF8C0ya3+5OGMoqd9HoYWr eV1El+y1hgPOc1JD2HjDxBOD7JrhwRZ9WCS/IIHgSQp2g+B6Ao8QGERe39kQoovIU6qR P/jw== X-Gm-Message-State: APzg51CRUtSH4IS3+KFRwLLhvK0XIho2g1pMNvPp6qA4jEICvlLUBBIC G4p5wAZBp9pfd5U37Sa51YsBHGKq X-Google-Smtp-Source: ANB0VdaNzGMOvVi3szbnsElEHKQPH9pVeEOdXYDACzRxdD45PWZHuufItLDCgqLmRipNRGy8vt2iog== X-Received: by 2002:a63:df4e:: with SMTP id h14-v6mr29246819pgj.300.1536029186942; Mon, 03 Sep 2018 19:46:26 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:26 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/25] staging: fwserial: Change return type to void Date: Tue, 4 Sep 2018 11:44:45 +0900 Message-Id: <1536029091-4426-20-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194637_647585_CCBD0A18 X-CRM114-Status: GOOD ( 12.39 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:542 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/staging/fwserial/fwserial.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c index fa0dd42..5134019 100644 --- a/drivers/staging/fwserial/fwserial.c +++ b/drivers/staging/fwserial/fwserial.c @@ -1064,27 +1064,21 @@ static void fwtty_cleanup(struct tty_struct *tty) static int fwtty_install(struct tty_driver *driver, struct tty_struct *tty) { struct fwtty_port *port = fwtty_port_get(tty->index); - int err; - err = tty_standard_install(driver, tty); - if (!err) - tty->driver_data = port; - else - fwtty_port_put(port); - return err; + tty_standard_install(driver, tty); + tty->driver_data = port; + + return 0; } static int fwloop_install(struct tty_driver *driver, struct tty_struct *tty) { struct fwtty_port *port = fwtty_port_get(table_idx(tty->index)); - int err; - err = tty_standard_install(driver, tty); - if (!err) - tty->driver_data = port; - else - fwtty_port_put(port); - return err; + tty_standard_install(driver, tty); + tty->driver_data = port; + + return 0; } static int fwtty_write(struct tty_struct *tty, const unsigned char *buf, int c)