Message ID | 20210722124814.778059-1-arnd@kernel.org |
---|---|
Headers | show
Return-Path: <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Ga0Plabm; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=uI8fZsAn; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GVtbV6CMPz9sfR for <incoming@patchwork.ozlabs.org>; Thu, 22 Jul 2021 23:29:42 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6lfCoxwZUvpg+tUZ50i5l8nCUQ50CGTzTXtWIg1zV+0=; b=Ga0Plabm3MX5i8 w09dt8Eo1Uvloxis0UlMpOYknOollmx/dFSdZ1c7vBlmpyniubdvVHT2Xvg1/iLT76xkAaRFCLu6U KoI8dw9c3XGz/3+z+5DZEfC3mIgG4NFItwRVK1P8qi7LgWzsKYMPrgqfseB3DqCZggAFmjCcqRbtr n9AL7UxmRHuDe32r2oNkAAJqxPmYa2fannHRM1afpKHd7OOqeO/gT33iNjKPRkKn9+Dv3lkIpy4dn 8nRgwR+u+5zvCDDoRnDaB1rLkldWeYaqlNpP3UiJwbpPYEkCMbGBHdl0qDIbDsOoG2fmXOWx/OkT/ tLw7B2JA9sRnMuXocl2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6Yla-001fO6-4E; Thu, 22 Jul 2021 13:29:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6Y8D-001XMG-Gl; Thu, 22 Jul 2021 12:48:55 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B77A61285; Thu, 22 Jul 2021 12:48:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626958132; bh=PX46ntR2F8mhtnTnqk6z0maUFKW3hKlsYGyDxWq8nt8=; h=From:To:Cc:Subject:Date:From; b=uI8fZsAnCujH8W7YiEBRgCAjHShI6gE1mvUR0l57R+InmBX0WanZ/uw9vRAOln3Z8 nGIW49oPfs3Z0oGoceXArCb+pcxtHVC7BDgIPVu7ZQgOSXVYcpE0fh0cemOAHYvVRq FKI2JY1Q7ji5J3em2CfLjWBtEWHTWOWxHMmXXgWyndwrPSlVntSikFKkr25MPmfWRd v73iMcJt52+PkD+rdPNKZ3PKisAXpGa6fQ8OZroEymMb7Gi2et/DUC63IcI09aav3H 3ECp+pAFmA7kucS8vsrWJ92J66Z8gjShxT5O7vJdnqnBEe0ThenTNBxBPkUxQ1dKDS brNKF2Qpg7HWw== From: Arnd Bergmann <arnd@kernel.org> To: linux-arch@vger.kernel.org Cc: Arnd Bergmann <arnd@arndb.de>, "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>, Al Viro <viro@zeniv.linux.org.uk>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Brian Cain <bcain@codeaurora.org>, Chris Zankel <chris@zankel.net>, Christian Borntraeger <borntraeger@de.ibm.com>, Christoph Hellwig <hch@lst.de>, Guo Ren <guoren@kernel.org>, Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>, Jeff Dike <jdike@addtoit.com>, Linus Walleij <linus.walleij@linaro.org>, Max Filippov <jcmvbkbc@gmail.com>, Michal Simek <monstr@monstr.eu>, Richard Weinberger <richard@nod.at>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Vasily Gorbik <gor@linux.ibm.com>, Vineet Gupta <vgupta@synopsys.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, uclinux-h8-devel@lists.sourceforge.jp Subject: [PATCH v3 0/6] asm-generic: strncpy_from_user/strnlen_user cleanup Date: Thu, 22 Jul 2021 14:48:05 +0200 Message-Id: <20210722124814.778059-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_054853_672513_F6B83885 X-CRM114-Status: GOOD ( 16.82 ) X-Spam-Score: -5.4 (-----) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arnd Bergmann <arnd@arndb.de> I had run into some regressions for the previous version of this series, the new version is based on v5.14-rc2 instead. These two functions appear to be unnecessarily different between architectures, and the asm-generic version is a bit questionable, even for NOMMU architectures. Content analysis details: (-5.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-um.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-um/> List-Post: <mailto:linux-um@lists.infradead.org> List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" <linux-um-bounces@lists.infradead.org> Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
asm-generic: strncpy_from_user/strnlen_user cleanup
|
expand
|
From: Arnd Bergmann <arnd@arndb.de> I had run into some regressions for the previous version of this series, the new version is based on v5.14-rc2 instead. These two functions appear to be unnecessarily different between architectures, and the asm-generic version is a bit questionable, even for NOMMU architectures. Clean this up to just use the generic library version for anything that uses the generic version today. I've expanded on the patch descriptions a little, as suggested by Christoph Hellwig, but I suspect a more detailed review would uncover additional problems with the custom versions that are getting removed. I ended up adding patches for csky and microblaze as they had the same implementation that I removed elsewhere, these are now gone as well. If I hear no objections from architecture maintainers or new build regressions, I'll queue these up in the asm-generic tree for 5.15. Arnd Link: https://lore.kernel.org/linux-arch/20210515101803.924427-1-arnd@kernel.org/ Arnd Bergmann (9): asm-generic/uaccess.h: remove __strncpy_from_user/__strnlen_user h8300: remove stale strncpy_from_user hexagon: use generic strncpy/strnlen from_user arc: use generic strncpy/strnlen from_user csky: use generic strncpy/strnlen from_user microblaze: use generic strncpy/strnlen from_user asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user asm-generic: remove extra strn{cpy_from,len}_user declarations asm-generic: reverse GENERIC_{STRNCPY_FROM,STRNLEN}_USER symbols arch/alpha/Kconfig | 2 - arch/arc/include/asm/uaccess.h | 72 ------------- arch/arc/mm/extable.c | 12 --- arch/arm/Kconfig | 2 - arch/arm64/Kconfig | 2 - arch/csky/include/asm/uaccess.h | 6 -- arch/csky/lib/usercopy.c | 102 ------------------ arch/h8300/kernel/h8300_ksyms.c | 2 - arch/h8300/lib/Makefile | 2 +- arch/h8300/lib/strncpy.S | 35 ------ arch/hexagon/include/asm/uaccess.h | 31 ------ arch/hexagon/kernel/hexagon_ksyms.c | 1 - arch/hexagon/mm/Makefile | 2 +- arch/hexagon/mm/strnlen_user.S | 126 ---------------------- arch/ia64/Kconfig | 2 + arch/m68k/Kconfig | 2 - arch/microblaze/include/asm/uaccess.h | 19 +--- arch/microblaze/kernel/microblaze_ksyms.c | 3 - arch/microblaze/lib/uaccess_old.S | 90 ---------------- arch/mips/Kconfig | 2 + arch/nds32/Kconfig | 2 - arch/nios2/Kconfig | 2 - arch/openrisc/Kconfig | 2 - arch/parisc/Kconfig | 2 +- arch/powerpc/Kconfig | 2 - arch/riscv/Kconfig | 2 - arch/s390/Kconfig | 2 + arch/sh/Kconfig | 2 - arch/sparc/Kconfig | 2 - arch/um/Kconfig | 2 + arch/um/include/asm/uaccess.h | 5 +- arch/um/kernel/skas/uaccess.c | 14 ++- arch/x86/Kconfig | 2 - arch/xtensa/Kconfig | 3 +- arch/xtensa/include/asm/uaccess.h | 3 +- include/asm-generic/uaccess.h | 52 ++------- lib/Kconfig | 10 +- 37 files changed, 43 insertions(+), 581 deletions(-) delete mode 100644 arch/h8300/lib/strncpy.S delete mode 100644 arch/hexagon/mm/strnlen_user.S