From patchwork Fri Jan 19 20:50:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 863801 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zNXzf6spYz9s4s for ; Sat, 20 Jan 2018 07:51:10 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755728AbeASUvJ (ORCPT ); Fri, 19 Jan 2018 15:51:09 -0500 Received: from mout.web.de ([212.227.17.12]:64050 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132AbeASUvI (ORCPT ); Fri, 19 Jan 2018 15:51:08 -0500 Received: from [192.168.1.3] ([78.53.251.71]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MHp4r-1egD404BCP-003aJN; Fri, 19 Jan 2018 21:50:58 +0100 To: iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, Hiroshi Doyu , =?utf-8?b?SsO2cmcgUsO2ZGVs?= , Jonathan Hunter , Thierry Reding Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] IOMMU-Tegra: gart: Delete two error messages for a failed memory allocation in tegra_gart_probe() Message-ID: Date: Fri, 19 Jan 2018 21:50:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 Content-Language: en-GB X-Provags-ID: V03:K0:Qv3pV+53prj/ZELF7VVM4/jPE3NN43IM3US/rHHybakQnyMdCHB 0IYjngE+1B3bQLx1SRFvm6i4lq7XDyQXWuie237STX/3SYSFxqd32NuZt+alKAUT9MnBgAI nOEI6sizKTEDPgXsyjqXQIoXZIjv6dOE5krcFAtOadAQt6Y+17W2wn98Jjso3JF74rRPI2g cWgrCeoUTEwGkfovVYT+Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:6TZ/1sG1Xbo=:upWls25qAXirwzX8mPC9X3 nSol1gZfEien3KsQOd+v8jQp4+8iQrAIGdgWDxdvVclVZbKMbaym0DmtHkKEN4vVlf//xHrSt jmffk580uWJkl1uSl5RNF0gWCpy5fYZdjEm0Exg16S+G/mXY/st6pP9PFRiu8hW0RxkMDiy5H T9bfxN4oI1a8XIpOZrcC7xRMxGuuHzzEIjJt7CVjTaYklu4RrHrBuxN3fBzEYm4KKQehfUm1h wqUuJOaa4lOISj+Am+FcRhgGMg62vrWPgTqdpsWx7pK1OX0CZgrdkLgoE8ClUq+e6RPVZlXeq RXYhkgPjusSVsPiiNdNsozcaZ3oHsZ4IRBTf8qgUijGkAPiuIas4asQsjtsnrD4bUxtmvl3F/ N8djQb8aLeHId6jvtWdzHhtYvQORvrHe32lv9ZZ0rFu6k7DuTzTz4b+M+SccaARkelCIbVMSx 7VAJyebkWvwman9xKoYUlaC4Lq7t0OBM6tTt+M4V2fiweLUrz0W1ZO2tiHEoJcjLfIL52bd1o FZTxIa/+lQMnqr2O58WDIs9JIdZoIJO44uhU8c2wSoJrBynFXtJBdhTc56+mjXjOr+T0dwDoe tdrTlb28Cd8lXq/32ztHrqGoykL8eNjVaBpDTN/VxaWMX4TivgcokWuV9GWUKXdJMVFFh4+Hq OAHTS8lIs6f2nMAIjOVQNMibCXs0v1Nf+qbcgV1yhr1jhamwmX7Bmpg2o/ll0EnPhopGU19n8 L5ywGA/+HfHLG+NTLynbEfu4sj1prjKGEp45IqVklSaZWUZVHpBNqHXxAYcP0RiYu4SiRw04E fhAafxupr6KqLb/Gh5YfFeR1uAwoJMUUb00lXBZeFvdN/3LL6Y= Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Markus Elfring Date: Fri, 19 Jan 2018 21:44:31 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iommu/tegra-gart.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c index b62f790ad1ba..1fee3a956832 100644 --- a/drivers/iommu/tegra-gart.c +++ b/drivers/iommu/tegra-gart.c @@ -419,10 +419,8 @@ static int tegra_gart_probe(struct platform_device *pdev) } gart = devm_kzalloc(dev, sizeof(*gart), GFP_KERNEL); - if (!gart) { - dev_err(dev, "failed to allocate gart_device\n"); + if (!gart) return -ENOMEM; - } gart_regs = devm_ioremap(dev, res->start, resource_size(res)); if (!gart_regs) { @@ -455,10 +453,8 @@ static int tegra_gart_probe(struct platform_device *pdev) gart->page_count = (resource_size(res_remap) >> GART_PAGE_SHIFT); gart->savedata = vmalloc(sizeof(u32) * gart->page_count); - if (!gart->savedata) { - dev_err(dev, "failed to allocate context save area\n"); + if (!gart->savedata) return -ENOMEM; - } platform_set_drvdata(pdev, gart); do_gart_setup(gart, NULL);