diff mbox

[v2,3/5] ARM: dt: tegra: add ADT7461 temperature sensor to paz00 device tree

Message ID 9421201.72pNsFM5zn@ax5200p
State Accepted, archived
Headers show

Commit Message

Marc Dietrich Jan. 31, 2012, 6:53 p.m. UTC
Add the ADT7461 temperature monitoring IC which is connected via
the DVC controller.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
---
 arch/arm/boot/dts/tegra-paz00.dts |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Comments

Stephen Warren Jan. 31, 2012, 7:55 p.m. UTC | #1
Marc Dietrich wrote at Tuesday, January 31, 2012 11:53 AM:
> Add the ADT7461 temperature monitoring IC which is connected via
> the DVC controller.
> 
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>

Acked-by: Stephen Warren <swarren@nvidia.com>
Olof Johansson Feb. 1, 2012, 8:26 a.m. UTC | #2
On Tue, Jan 31, 2012 at 07:53:21PM +0100, Marc Dietrich wrote:
> Add the ADT7461 temperature monitoring IC which is connected via
> the DVC controller.
> 
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> ---
>  arch/arm/boot/dts/tegra-paz00.dts |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-
> paz00.dts
> index f667343..81e1d30 100644
> --- a/arch/arm/boot/dts/tegra-paz00.dts
> +++ b/arch/arm/boot/dts/tegra-paz00.dts
> @@ -35,6 +35,11 @@
>  
>         i2c@7000d000 {
>                 clock-frequency = <400000>;
> +
> +               adt7461@4c {
> +                       compatible = "adi,adt7461";
> +                       reg = <0x4c>;
> +               };

It's common to name the device node temp-sensor (or temperature-sensor) instead
of the model of the actual chip. The name isn't significant for the binding,
but it's a practice that's been used on other platforms for a long time.

I'll just fix it up when applying, if ok with you. No need to respin just for
this.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marc Dietrich Feb. 1, 2012, 9:41 a.m. UTC | #3
Am Mittwoch, 1. Februar 2012, 00:26:04 schrieb Olof Johansson:
> On Tue, Jan 31, 2012 at 07:53:21PM +0100, Marc Dietrich wrote:
> > Add the ADT7461 temperature monitoring IC which is connected via
> > the DVC controller.
> > 
> > Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> > ---
> > 
> >  arch/arm/boot/dts/tegra-paz00.dts |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-
> > paz00.dts
> > index f667343..81e1d30 100644
> > --- a/arch/arm/boot/dts/tegra-paz00.dts
> > +++ b/arch/arm/boot/dts/tegra-paz00.dts
> > @@ -35,6 +35,11 @@
> > 
> >         i2c@7000d000 {
> >         
> >                 clock-frequency = <400000>;
> > 
> > +
> > +               adt7461@4c {
> > +                       compatible = "adi,adt7461";
> > +                       reg = <0x4c>;
> > +               };
> 
> It's common to name the device node temp-sensor (or temperature-sensor) instead
> of the model of the actual chip. The name isn't significant for the binding,
> but it's a practice that's been used on other platforms for a long time.
> 
> I'll just fix it up when applying, if ok with you. No need to respin just for
> this.

Renaming it to something like "temp-sensor" is also ok for me. Feel free to change 
this.

Thanks!

Marc


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-
paz00.dts
index f667343..81e1d30 100644
--- a/arch/arm/boot/dts/tegra-paz00.dts
+++ b/arch/arm/boot/dts/tegra-paz00.dts
@@ -35,6 +35,11 @@ 
 
        i2c@7000d000 {
                clock-frequency = <400000>;
+
+               adt7461@4c {
+                       compatible = "adi,adt7461";
+                       reg = <0x4c>;
+               };
        };
 
        i2s@70002800 {