| Message ID | 20240216123057.33018-2-jonathanh@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] memory: tegra: Fix indentation | expand |
On 16/02/2024 13:30, Jon Hunter wrote: > Correct the DLA memory client names for Tegra234 to align with the > memory client IDs. That's a fix, so what's a effect of the bug? Also, all fixes cannot be after cleanups. Put it first in the patchset. Best regards, Krzysztof
On 17/02/2024 10:06, Krzysztof Kozlowski wrote: > On 16/02/2024 13:30, Jon Hunter wrote: >> Correct the DLA memory client names for Tegra234 to align with the >> memory client IDs. > > That's a fix, so what's a effect of the bug? Right now, it fixes some print messages in the driver, but we really need to correct this before adding interconnect support for the DLA clients in patch 3/3 where the name is also used. > Also, all fixes cannot be after cleanups. Put it first in the patchset. Yes indeed. I will re-order and update the commit message for this change. Thanks Jon
On 19/02/2024 13:29, Jon Hunter wrote: > > On 17/02/2024 10:06, Krzysztof Kozlowski wrote: >> On 16/02/2024 13:30, Jon Hunter wrote: >>> Correct the DLA memory client names for Tegra234 to align with the >>> memory client IDs. >> >> That's a fix, so what's a effect of the bug? > > Right now, it fixes some print messages in the driver, but we really > need to correct this before adding interconnect support for the DLA > clients in patch 3/3 where the name is also used. Would be nice to mention in the commit msg the impact of the issue being fixed. > >> Also, all fixes cannot be after cleanups. Put it first in the patchset. > > Yes indeed. I will re-order and update the commit message for this change. Best regards, Krzysztof
diff --git a/drivers/memory/tegra/tegra234.c b/drivers/memory/tegra/tegra234.c index e6476b6ad923..27383eb08b45 100644 --- a/drivers/memory/tegra/tegra234.c +++ b/drivers/memory/tegra/tegra234.c @@ -121,7 +121,7 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { }, }, { .id = TEGRA234_MEMORY_CLIENT_DLA1RDB, - .name = "dla0rdb", + .name = "dla1rdb", .sid = TEGRA234_SID_NVDLA1, .regs = { .sid = { @@ -407,7 +407,7 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { }, }, { .id = TEGRA234_MEMORY_CLIENT_DLA1RDB1, - .name = "dla0rdb1", + .name = "dla1rdb1", .sid = TEGRA234_SID_NVDLA1, .regs = { .sid = { @@ -417,7 +417,7 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { }, }, { .id = TEGRA234_MEMORY_CLIENT_DLA1WRB, - .name = "dla0wrb", + .name = "dla1wrb", .sid = TEGRA234_SID_NVDLA1, .regs = { .sid = { @@ -699,7 +699,7 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { }, }, { .id = TEGRA234_MEMORY_CLIENT_DLA1RDA, - .name = "dla0rda", + .name = "dla1rda", .sid = TEGRA234_SID_NVDLA1, .regs = { .sid = { @@ -709,7 +709,7 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { }, }, { .id = TEGRA234_MEMORY_CLIENT_DLA1FALRDB, - .name = "dla0falrdb", + .name = "dla1falrdb", .sid = TEGRA234_SID_NVDLA1, .regs = { .sid = { @@ -719,7 +719,7 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { }, }, { .id = TEGRA234_MEMORY_CLIENT_DLA1WRA, - .name = "dla0wra", + .name = "dla1wra", .sid = TEGRA234_SID_NVDLA1, .regs = { .sid = { @@ -729,7 +729,7 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { }, }, { .id = TEGRA234_MEMORY_CLIENT_DLA1FALWRB, - .name = "dla0falwrb", + .name = "dla1falwrb", .sid = TEGRA234_SID_NVDLA1, .regs = { .sid = { @@ -917,7 +917,7 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { }, }, { .id = TEGRA234_MEMORY_CLIENT_DLA1RDA1, - .name = "dla0rda1", + .name = "dla1rda1", .sid = TEGRA234_SID_NVDLA1, .regs = { .sid = {
Correct the DLA memory client names for Tegra234 to align with the memory client IDs. Fixes: 6d0c4aa51628 ("memory: tegra: sort tegra234_mc_clients table as per register offsets") Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- drivers/memory/tegra/tegra234.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)