| Message ID | 20240215224301.2073845-1-colin.i.king@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [next] gpu: host1x: remove redundant assignment to variable space | expand |
On Thu Feb 15, 2024 at 11:43 PM CET, Colin Ian King wrote: > The variable space is being initialized with a value that is never read, > it is being re-assigned later on. The initialization is redundant and > can be removed. Also merge two declaration lines together. > > Cleans up clang scan build warning: > drivers/gpu/host1x/cdma.c:628:15: warning: Value stored to 'space' > during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/gpu/host1x/cdma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied to drm-misc-next, thanks. Thierry
diff --git a/drivers/gpu/host1x/cdma.c b/drivers/gpu/host1x/cdma.c index d1336e438f4f..407ed9b9cf64 100644 --- a/drivers/gpu/host1x/cdma.c +++ b/drivers/gpu/host1x/cdma.c @@ -625,8 +625,7 @@ void host1x_cdma_push_wide(struct host1x_cdma *cdma, u32 op1, u32 op2, struct host1x_channel *channel = cdma_to_channel(cdma); struct host1x *host1x = cdma_to_host1x(cdma); struct push_buffer *pb = &cdma->push_buffer; - unsigned int space = cdma->slots_free; - unsigned int needed = 2, extra = 0; + unsigned int space, needed = 2, extra = 0; if (host1x_debug_trace_cmdbuf) trace_host1x_cdma_push_wide(dev_name(channel->dev), op1, op2,
The variable space is being initialized with a value that is never read, it is being re-assigned later on. The initialization is redundant and can be removed. Also merge two declaration lines together. Cleans up clang scan build warning: drivers/gpu/host1x/cdma.c:628:15: warning: Value stored to 'space' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/gpu/host1x/cdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)