| Message ID | 20240111174436.183920-1-pbrobinson@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA | expand |
On 11/01/2024 17:44, Peter Robinson wrote: > Update the architecture dependency to be the generic Tegra > because the driver works on the four latest Tegra generations > not just T210, if you build a kernel with a specific > ARCH_TEGRA_xxx_SOC optioon that excludes 210 you don't get s/optioon/option :-) > this driver. > > Fixes: 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194") > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > Cc: Jon Hunter <jonathanh@nvidia.com> > Cc: Thierry Reding <treding@nvidia.com> > Cc: Sameer Pujar <spujar@nvidia.com> > Cc: Laxman Dewangan <ldewangan@nvidia.com> > --- > drivers/dma/Kconfig | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index 70ba506dabab5..de6eb370d485d 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -629,16 +629,16 @@ config TEGRA20_APB_DMA > > config TEGRA210_ADMA > tristate "NVIDIA Tegra210 ADMA support" > - depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST) > + depends on (ARCH_TEGRA || COMPILE_TEST) > select DMA_ENGINE > select DMA_VIRTUAL_CHANNELS > help > - Support for the NVIDIA Tegra210 ADMA controller driver. The > - DMA controller has multiple DMA channels and is used to service > - various audio clients in the Tegra210 audio processing engine > - (APE). This DMA controller transfers data from memory to > - peripheral and vice versa. It does not support memory to > - memory data transfer. > + Support for the NVIDIA Tegra210/Tegra186/Tegra194/Tegra234 ADMA > + controller driver. The DMA controller has multiple DMA channels > + and is used to service various audio clients in the Tegra210 > + audio processing engine (APE). This DMA controller transfers > + data from memory to peripheral and vice versa. It does not > + support memory to memory data transfer. > > config TIMB_DMA > tristate "Timberdale FPGA DMA support" Looks good to me. Thanks for fixing! Apart from the minor typo ... Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Jon
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 70ba506dabab5..de6eb370d485d 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -629,16 +629,16 @@ config TEGRA20_APB_DMA config TEGRA210_ADMA tristate "NVIDIA Tegra210 ADMA support" - depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST) + depends on (ARCH_TEGRA || COMPILE_TEST) select DMA_ENGINE select DMA_VIRTUAL_CHANNELS help - Support for the NVIDIA Tegra210 ADMA controller driver. The - DMA controller has multiple DMA channels and is used to service - various audio clients in the Tegra210 audio processing engine - (APE). This DMA controller transfers data from memory to - peripheral and vice versa. It does not support memory to - memory data transfer. + Support for the NVIDIA Tegra210/Tegra186/Tegra194/Tegra234 ADMA + controller driver. The DMA controller has multiple DMA channels + and is used to service various audio clients in the Tegra210 + audio processing engine (APE). This DMA controller transfers + data from memory to peripheral and vice versa. It does not + support memory to memory data transfer. config TIMB_DMA tristate "Timberdale FPGA DMA support"
Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC optioon that excludes 210 you don't get this driver. Fixes: 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194") Signed-off-by: Peter Robinson <pbrobinson@gmail.com> Cc: Jon Hunter <jonathanh@nvidia.com> Cc: Thierry Reding <treding@nvidia.com> Cc: Sameer Pujar <spujar@nvidia.com> Cc: Laxman Dewangan <ldewangan@nvidia.com> --- drivers/dma/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)