diff mbox series

arm64: tegra: Enable IOMMU for host1x on Tegra132

Message ID 20230810214543.16235-1-rayyan@ansari.sh
State Accepted
Headers show
Series arm64: tegra: Enable IOMMU for host1x on Tegra132 | expand

Commit Message

Rayyan Ansari Aug. 10, 2023, 9:45 p.m. UTC
Add the iommu property to the host1x node to register it with its
swgroup.

Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
---
 arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thierry Reding Aug. 16, 2023, 4:24 p.m. UTC | #1
On Thu, Aug 10, 2023 at 10:45:41PM +0100, Rayyan Ansari wrote:
> Add the iommu property to the host1x node to register it with its
> swgroup.
> 
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> ---
>  arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 ++
>  1 file changed, 2 insertions(+)

Do you happen to have a Tegra132 device that you can test upstream Linux
on? Just asking out of curiosity because these devices are becoming very
rare these days and it'd be good to know if people are still using these
and that recent Linux kernels are still running on them.

Thierry
Thierry Reding Aug. 16, 2023, 4:24 p.m. UTC | #2
From: Thierry Reding <treding@nvidia.com>


On Thu, 10 Aug 2023 22:45:41 +0100, Rayyan Ansari wrote:
> Add the iommu property to the host1x node to register it with its
> swgroup.
> 
> 

Applied, thanks!

[1/1] arm64: tegra: Enable IOMMU for host1x on Tegra132
      commit: ffca3ccbe50e12a83facfc7e9beabd1851345fa0

Best regards,
Rayyan Ansari Aug. 16, 2023, 7:56 p.m. UTC | #3
On 16/08/2023 17:24, Thierry Reding wrote:
> On Thu, Aug 10, 2023 at 10:45:41PM +0100, Rayyan Ansari wrote:
>> Add the iommu property to the host1x node to register it with its
>> swgroup.
>>
>> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
>> ---
>>   arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 ++
>>   1 file changed, 2 insertions(+)
> 
> Do you happen to have a Tegra132 device that you can test upstream Linux
> on? Just asking out of curiosity because these devices are becoming very
> rare these days and it'd be good to know if people are still using these
> and that recent Linux kernels are still running on them.

I do - I have the Nexus 9. At some point I was trying to mainline it, 
but I stopped as I couldn't manage to get USB working - I only got 
simplefb working. If it would be useful I could see if my old patches 
work now and submit them.

> 
> Thierry
Rayyan Ansari Aug. 16, 2023, 8:09 p.m. UTC | #4
On 16/08/2023 20:56, Rayyan Ansari wrote:
> On 16/08/2023 17:24, Thierry Reding wrote:
>> On Thu, Aug 10, 2023 at 10:45:41PM +0100, Rayyan Ansari wrote:
>>> Add the iommu property to the host1x node to register it with its
>>> swgroup.
>>>
>>> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
>>> ---
>>>   arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 ++
>>>   1 file changed, 2 insertions(+)
>>
>> Do you happen to have a Tegra132 device that you can test upstream Linux
>> on? Just asking out of curiosity because these devices are becoming very
>> rare these days and it'd be good to know if people are still using these
>> and that recent Linux kernels are still running on them.
> 
> I do - I have the Nexus 9. At some point I was trying to mainline it, 
> but I stopped as I couldn't manage to get USB working - I only got 
> simplefb working. If it would be useful I could see if my old patches 
> work now and submit them.

I looked through my old notes and I was able to get USB host mode (ie 
USB OTG) working but not USB device mode.

> 
>>
>> Thierry
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
index 8b78be8f4f9d..7e24a212c7e4 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
@@ -93,6 +93,8 @@  host1x@50000000 {
 		resets = <&tegra_car 28>;
 		reset-names = "host1x";
 
+		iommus = <&mc TEGRA_SWGROUP_HC>;
+
 		#address-cells = <2>;
 		#size-cells = <2>;