| Message ID | 20230809-pca9450-reboot-v2-2-b98b4f8139d5@skidata.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | regulator: pca9450: register restart handlers | expand |
On Wed, 09 Aug 2023, Benjamin Bara wrote: > From: Benjamin Bara <benjamin.bara@skidata.com> > > The current restart handler registration does not specify whether the > restart is a cold or a warm one. Instead, cold ones are typically > registered with a HIGH prio. Now, as do_kernel_restart() knows about the > type, the priorization is implicitly done (cold restarts are executed > first) and the reboot_mode kernel parameter (which is currently mostly > ignored) can be respected. > > Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com> > --- > v2: > - improve commit message > - use registration helper instead > --- > drivers/mfd/rk8xx-core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c > index 11a831e92da8..7faf8e1189f7 100644 > --- a/drivers/mfd/rk8xx-core.c > +++ b/drivers/mfd/rk8xx-core.c > @@ -696,9 +696,9 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap > switch (rk808->variant) { > case RK809_ID: > case RK817_ID: > - ret = devm_register_sys_off_handler(dev, > - SYS_OFF_MODE_RESTART, SYS_OFF_PRIO_HIGH, > - &rk808_restart, rk808); > + ret = devm_register_cold_restart_handler(dev, > + &rk808_restart, > + rk808); These wraps are now superfluous. > if (ret) > dev_warn(dev, "failed to register rst handler, %d\n", ret); > break; > > -- > 2.34.1 >
diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c index 11a831e92da8..7faf8e1189f7 100644 --- a/drivers/mfd/rk8xx-core.c +++ b/drivers/mfd/rk8xx-core.c @@ -696,9 +696,9 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap switch (rk808->variant) { case RK809_ID: case RK817_ID: - ret = devm_register_sys_off_handler(dev, - SYS_OFF_MODE_RESTART, SYS_OFF_PRIO_HIGH, - &rk808_restart, rk808); + ret = devm_register_cold_restart_handler(dev, + &rk808_restart, + rk808); if (ret) dev_warn(dev, "failed to register rst handler, %d\n", ret); break;