| Message ID | 20230713072825.10348-1-duminjie@vivo.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init() | expand |
On 2023/7/13 15:28, Minjie Du wrote: > debugfs_create_file() will return early if smmu->debugfs is an error > pointer, so an extra error check is not needed. > > Signed-off-by: Minjie Du <duminjie@vivo.com> > Acked-by: Thierry Reding <treding@nvidia.com> > --- > drivers/iommu/tegra-smmu.c | 2 -- > 1 file changed, 2 deletions(-) Next time when you send a new version of a patch, please don't forget to add the change log after the tear line. This way, people can know how the patch evolved into this way. Best regards, baolu > > diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c > index 1cbf063cc..2137040b7 100644 > --- a/drivers/iommu/tegra-smmu.c > +++ b/drivers/iommu/tegra-smmu.c > @@ -1056,8 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); > static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) > { > smmu->debugfs = debugfs_create_dir("smmu", NULL); > - if (!smmu->debugfs) > - return; > > debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu, > &tegra_smmu_swgroups_fops);
On 2023/7/14 10:38, 杜敏杰 wrote: > Hi baolu! > > Thanks for your suggestion! > > You say: >> Next time when you send a new version of a patch, please don't forget to add the change log after the tear line. This way, people can know how the patch evolved into this way. > Do I need to submit a new patch? Oh no. Just a kind remind. :-) Best regards, baolu
On 2023/7/13 15:28, Minjie Du wrote: > debugfs_create_file() will return early if smmu->debugfs is an error > pointer, so an extra error check is not needed. > > Signed-off-by: Minjie Du<duminjie@vivo.com> > Acked-by: Thierry Reding<treding@nvidia.com> Greg keeps reminding that no error branch for debugfs, so Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com> Best regards, baolu
On Fri, Jul 14, 2023 at 03:21:47AM +0000, 杜敏杰 wrote: > Hi Baolu! > > It seems that 'smmu->debugfs' check is still needed. > Then I will modify the patch. > Thanks! > > regards, > Minjie Don't top-post, please. See Documentation/process/2.Process.rst and Documentation/process/submitting-patches.rst. Also, how did you come to the above conclusion? Baolu said that Greg keeps reminding people that we shouldn't do error handling for debugfs and gave a Reviewed-by:, so why the 180? Thierry > -----邮件原件----- > 发件人: Baolu Lu <baolu.lu@linux.intel.com> > 发送时间: 2023年7月14日 10:58 > 收件人: 杜敏杰 <duminjie@vivo.com>; Thierry Reding <thierry.reding@gmail.com>; Krishna Reddy <vdumpa@nvidia.com>; Joerg Roedel <joro@8bytes.org>; Will Deacon <will@kernel.org>; Robin Murphy <robin.murphy@arm.com>; Jonathan Hunter <jonathanh@nvidia.com>; open list:TEGRA IOMMU DRIVERS <linux-tegra@vger.kernel.org>; open list:IOMMU SUBSYSTEM <iommu@lists.linux.dev>; open list <linux-kernel@vger.kernel.org> > 抄送: baolu.lu@linux.intel.com; opensource.kernel <opensource.kernel@vivo.com>; Thierry Reding <treding@nvidia.com> > 主题: Re: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init() > > [Some people who received this message don't often get email from baolu.lu@linux.intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > On 2023/7/13 15:28, Minjie Du wrote: > > debugfs_create_file() will return early if smmu->debugfs is an error > > pointer, so an extra error check is not needed. > > > > Signed-off-by: Minjie Du<duminjie@vivo.com> > > Acked-by: Thierry Reding<treding@nvidia.com> > > Greg keeps reminding that no error branch for debugfs, so > > Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com> > > Best regards, > baolu
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index 1cbf063cc..2137040b7 100644 --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -1056,8 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) { smmu->debugfs = debugfs_create_dir("smmu", NULL); - if (!smmu->debugfs) - return; debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu, &tegra_smmu_swgroups_fops);