| Message ID | 20230712113145.12888-1-duminjie@vivo.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v1] iommu: fix parameter check in tegra_smmu_debugfs_init() | expand |
On Wed, Jul 12, 2023 at 07:31:45PM +0800, Minjie Du wrote: > Make IS_ERR() judge the debugfs_create_dir() function return > in tegra_smmu_debugfs_init() > > Signed-off-by: Minjie Du <duminjie@vivo.com> > --- > drivers/iommu/tegra-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c > index 1cbf063cc..841e14cce 100644 > --- a/drivers/iommu/tegra-smmu.c > +++ b/drivers/iommu/tegra-smmu.c > @@ -1056,7 +1056,7 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); > static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) > { > smmu->debugfs = debugfs_create_dir("smmu", NULL); > - if (!smmu->debugfs) > + if (IS_ERR(smmu->debugfs)) > return; I think we can just drop the error check altogether since debugfs_create_file() will simply return early if smmu->debugfs is an error pointer. Thierry
On Wed, Jul 12, 2023 at 12:37:02PM +0000, 杜敏杰 wrote: > Hi Thierry! > > >I think we can just drop the error check altogether since > >debugfs_create_file() will simply return early if smmu->debugfs is an error pointer. > > So do you mean maybe delete the smmu->debugfs check is better? > Maybe I can resubmit a new patch. Yes, I think that would be preferable. Thierry
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index 1cbf063cc..841e14cce 100644 --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -1056,7 +1056,7 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) { smmu->debugfs = debugfs_create_dir("smmu", NULL); - if (!smmu->debugfs) + if (IS_ERR(smmu->debugfs)) return; debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
Make IS_ERR() judge the debugfs_create_dir() function return in tegra_smmu_debugfs_init() Signed-off-by: Minjie Du <duminjie@vivo.com> --- drivers/iommu/tegra-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)