diff mbox series

ASoC: tegra20_ac97: Add missing unwind goto in tegra20_ac97_platform_probe()

Message ID 20230404084622.1202-1-u202012060@hust.edu.cn
State Handled Elsewhere
Headers show
Series ASoC: tegra20_ac97: Add missing unwind goto in tegra20_ac97_platform_probe() | expand

Commit Message

Zihao Wang April 4, 2023, 8:46 a.m. UTC 
Smatch Warns:
	sound/soc/tegra/tegra20_ac97.c:321 tegra20_ac97_platform_probe()
	warn: missing unwind goto?

The goto will set the "soc_ac97_ops" and "soc_ac97_bus" operations to
NULL.  But they are already NULL at this point so it is a no-op.
However, just for consistency, change the direct return to a goto.  No
functional change.

Signed-off-by: Zihao Wang <u202012060@hust.edu.cn>
Reviewed-by: Dan Carpenter <error27@gmail.com>
---
 sound/soc/tegra/tegra20_ac97.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Mark Brown April 4, 2023, 1:45 p.m. UTC | #1 
On Tue, 04 Apr 2023 16:46:22 +0800, Zihao Wang wrote:
> Smatch Warns:
> 	sound/soc/tegra/tegra20_ac97.c:321 tegra20_ac97_platform_probe()
> 	warn: missing unwind goto?
> 
> The goto will set the "soc_ac97_ops" and "soc_ac97_bus" operations to
> NULL.  But they are already NULL at this point so it is a no-op.
> However, just for consistency, change the direct return to a goto.  No
> functional change.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: tegra20_ac97: Add missing unwind goto in tegra20_ac97_platform_probe()
      commit: 194f8692302cbf31d8072f3fc2710fb04720d8a0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c
index d23d88a10899..d00449441e5e 100644
--- a/sound/soc/tegra/tegra20_ac97.c
+++ b/sound/soc/tegra/tegra20_ac97.c
@@ -318,7 +318,8 @@  static int tegra20_ac97_platform_probe(struct platform_device *pdev)
 	ac97->reset = devm_reset_control_get_exclusive(&pdev->dev, "ac97");
 	if (IS_ERR(ac97->reset)) {
 		dev_err(&pdev->dev, "Can't retrieve ac97 reset\n");
-		return PTR_ERR(ac97->reset);
+		ret = PTR_ERR(ac97->reset);
+		goto err;
 	}
 
 	ac97->clk_ac97 = devm_clk_get(&pdev->dev, NULL);