| Message ID | 20230322054051.GA150453@sumitra.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [v4] Staging: nvec: Remove macro definition to_nvec_led | expand |
Sumitra Sharma wrote: > Remove definition 'to_nvec_led' because it is only used once. > Rewrite the code directly in the calling function > 'nvec_led_brightness_set'. > > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
diff --git a/drivers/staging/nvec/nvec_paz00.c b/drivers/staging/nvec/nvec_paz00.c index 8b4da95081c8..55d59840fca4 100644 --- a/drivers/staging/nvec/nvec_paz00.c +++ b/drivers/staging/nvec/nvec_paz00.c @@ -14,9 +14,6 @@ #include <linux/platform_device.h> #include "nvec.h" -#define to_nvec_led(led_cdev) \ - container_of(led_cdev, struct nvec_led, cdev) - #define NVEC_LED_REQ {'\x0d', '\x10', '\x45', '\x10', '\x00'} #define NVEC_LED_MAX 8 @@ -29,7 +26,7 @@ struct nvec_led { static void nvec_led_brightness_set(struct led_classdev *led_cdev, enum led_brightness value) { - struct nvec_led *led = to_nvec_led(led_cdev); + struct nvec_led *led = container_of(led_cdev, struct nvec_led, cdev); unsigned char buf[] = NVEC_LED_REQ; buf[4] = value;
Remove definition 'to_nvec_led' because it is only used once. Rewrite the code directly in the calling function 'nvec_led_brightness_set'. Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com> --- v2: Change patch subject and description, noted by Julia Lawall <julia.lawall@inria.fr> v3: Remove macro definition 'to_nvec_led' Change subject and description, noted by Greg Kroah-Hartman <gregkh@linuxfoundation.org> drivers/staging/nvec/nvec_paz00.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)