| Message ID | 20230318144412.75046-6-frank.li@vivo.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | None | expand |
On Sat, Mar 18, 2023 at 10:44:09PM +0800, Yangtao Li wrote: > The upper-layer devm_thermal_add_hwmon_sysfs() function can directly > print error information. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > drivers/thermal/tegra/tegra30-tsensor.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/tegra/tegra30-tsensor.c > index cb584a5735ed..c243e9d76d3c 100644 > --- a/drivers/thermal/tegra/tegra30-tsensor.c > +++ b/drivers/thermal/tegra/tegra30-tsensor.c > @@ -523,8 +523,7 @@ static int tegra_tsensor_register_channel(struct tegra_tsensor *ts, > return 0; > } > > - if (devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd)) > - dev_warn(ts->dev, "failed to add hwmon sysfs attributes\n"); > + devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd); I don't see any error messages output by devm_thermal_add_hwmon_sysfs() nor any of the functions that it calls. Did I miss something? Thierry
diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/tegra/tegra30-tsensor.c index cb584a5735ed..c243e9d76d3c 100644 --- a/drivers/thermal/tegra/tegra30-tsensor.c +++ b/drivers/thermal/tegra/tegra30-tsensor.c @@ -523,8 +523,7 @@ static int tegra_tsensor_register_channel(struct tegra_tsensor *ts, return 0; } - if (devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd)) - dev_warn(ts->dev, "failed to add hwmon sysfs attributes\n"); + devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd); return 0; }
The upper-layer devm_thermal_add_hwmon_sysfs() function can directly print error information. Signed-off-by: Yangtao Li <frank.li@vivo.com> --- drivers/thermal/tegra/tegra30-tsensor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)